Hi On Fri, Feb 07, 2025 at 02:39:56AM +0000, Soft Works wrote: > > > > -----Original Message----- > > From: Steven Liu > > Sent: Friday, February 7, 2025 3:24 AM > > To: FFmpeg development discussions and patches > devel@ffmpeg.org> > > Cc: softworkz > > Subject: Re: [FFmpeg-devel] [PATCH] avformat/hls: Revert "reduce > > default max reload to 3" > > > > softworkz 于2025年1月19日周日 16:52写道: > > > > > > From: softworkz > > > > > > This change has caused regressions for many users and consumers. > > > Playlist reloads only happen when a playlist doesn't indicate that > > it > > > has ended (via #EXT-X-ENDLIST), which means that the addition of > > future > > > segments is still expected. > > > It is well possible that an HLS server is temporarily unable to > > serve > > > further segments but resumes after some time, either indicating a > > > discontinuity or even by fully catching up. > > > With a segment length of 3s, a max_reload value of 1000 corresponds > > to > > > a duration of 50 minutes which appears to be a reasonable default. > > Hi Steven, > > thanks for reviewing > > > I have no opinion about this, lgtm > > Neither do I. As this is a reversion, I meant to say that the original value wasn't irrational as it might have appeared when the change to 3 was made. > Whether it's 100, 1000 or 10000 might be debatable, just 3 is way too low, so without any strong reason towards 100 or 10000, I think that going back to the original value makes the most sense. If 3 is too small and 1000 is too large then try the value in the middle sqrt(3*1000) = ~50 thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequality is to try to make unequal things equal. -- Aristotle