From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D622F4CAB9 for ; Mon, 24 Feb 2025 08:05:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F2E7768CC79; Mon, 24 Feb 2025 10:04:45 +0200 (EET) Received: from vidala.pars.ee (vidala.pars.ee [116.203.72.101]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 283AE68CB27 for ; Mon, 24 Feb 2025 10:04:39 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; s=202405r; d=lynne.ee; c=relaxed/relaxed; h=Message-ID:Date:Subject:To:From; t=1740384277; bh=sErnXcv9t73bq23UDBaxlTY l16oRwMjMwIVqPXH9CIE=; b=FBjpcEoOKFiB1Bx09wg35G6uaXEpsfrWovNAJj6UPHS8gaCQPF YGtMGIywHx5QBMuatauK3VFV5RSzaT5Pn72KtPasUSPYERTsYZow/wIjUHaugARXAjD6nE7+p4Q 1sO+5waq8GPrtxC8BZw15QASE8V+9mWSoV5dhXCmKYL08ebiWUh28yiRxRCrFYHqKLrLuqB8dek 8Z1Olg9EzUxio5EdR12FTIfGfuJdYDhkBBrV1i9cpHg1icT6GwPZuLRZhBkkLxQPK3vlm2cmo9P 22zSRdl6i/e66QP62/bqz6Jtr66e0aum6rdKmHd6KUytcKkcsE+3snmMZaxXZPN+35A==; DKIM-Signature: v=1; a=ed25519-sha256; s=202405e; d=lynne.ee; c=relaxed/relaxed; h=Message-ID:Date:Subject:To:From; t=1740384277; bh=sErnXcv9t73bq23UDBaxlTY l16oRwMjMwIVqPXH9CIE=; b=S8QcJILmgDroOImgIr3LpzC2o0n1UBDPpU22urE4tIRnWb85vN phWx75uzRaZOsxCU+H6+ZEbCzQbHt8M+q5Bw==; From: Lynne To: ffmpeg-devel@ffmpeg.org Date: Mon, 24 Feb 2025 09:04:14 +0100 Message-ID: <20250224080434.5632-1-dev@lynne.ee> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 01/12] ffv1enc_vulkan: disable autodetection of async_depth X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Lynne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: The issue is that this could consume gigabytes of VRAM at higher resolutions for not that much of a speedup. Automatic detection was not a good idea as we can't know how much VRAM is actually free. Just remove it. --- libavcodec/ffv1enc_vulkan.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/libavcodec/ffv1enc_vulkan.c b/libavcodec/ffv1enc_vulkan.c index 3d7ee073aa..6a12ee2055 100644 --- a/libavcodec/ffv1enc_vulkan.c +++ b/libavcodec/ffv1enc_vulkan.c @@ -1631,11 +1631,6 @@ static av_cold int vulkan_encode_ffv1_init(AVCodecContext *avctx) max_heap_size = max_heap_size - (max_heap_size >> 3); } - if (!fv->async_depth) { - fv->async_depth = FFMIN(fv->qf->num, FFMAX(max_heap_size / maxsize, 1)); - fv->async_depth = FFMAX(fv->async_depth, 1); - } - av_log(avctx, AV_LOG_INFO, "Async buffers: %zuMiB per context, %zuMiB total, depth: %i\n", maxsize / (1024*1024), (fv->async_depth * maxsize) / (1024*1024), @@ -1820,7 +1815,7 @@ static const AVOption vulkan_encode_ffv1_options[] = { { .i64 = 0 }, 0, 1, VE }, { "async_depth", "Internal parallelization depth", OFFSET(async_depth), AV_OPT_TYPE_INT, - { .i64 = 0 }, 0, INT_MAX, VE }, + { .i64 = 1 }, 1, INT_MAX, VE }, { NULL } }; -- 2.47.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".