* [FFmpeg-devel] [PATCH] fftools: notify user of flags upon loglevel parse failure
@ 2025-02-20 10:06 Gyan Doshi
2025-02-21 8:51 ` Andreas Rheinhardt
0 siblings, 1 reply; 5+ messages in thread
From: Gyan Doshi @ 2025-02-20 10:06 UTC (permalink / raw)
To: ffmpeg-devel
---
fftools/opt_common.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/fftools/opt_common.c b/fftools/opt_common.c
index 317e8458c1..2ac3fd4fb3 100644
--- a/fftools/opt_common.c
+++ b/fftools/opt_common.c
@@ -1330,6 +1330,11 @@ int opt_loglevel(void *optctx, const char *opt, const char *arg)
"Possible levels are numbers or:\n", arg);
for (i = 0; i < FF_ARRAY_ELEMS(log_levels); i++)
av_log(NULL, AV_LOG_FATAL, "\"%s\"\n", log_levels[i].name);
+ av_log(NULL, AV_LOG_FATAL, "Possible flags are:\n");
+ av_log(NULL, AV_LOG_FATAL, "\"repeat\"\n");
+ av_log(NULL, AV_LOG_FATAL, "\"level\"\n");
+ av_log(NULL, AV_LOG_FATAL, "\"time\"\n");
+ av_log(NULL, AV_LOG_FATAL, "\"datetime\"\n");
return AVERROR(EINVAL);
}
--
2.46.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] fftools: notify user of flags upon loglevel parse failure
2025-02-20 10:06 [FFmpeg-devel] [PATCH] fftools: notify user of flags upon loglevel parse failure Gyan Doshi
@ 2025-02-21 8:51 ` Andreas Rheinhardt
2025-02-21 9:53 ` Gyan Doshi
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Rheinhardt @ 2025-02-21 8:51 UTC (permalink / raw)
To: ffmpeg-devel
Gyan Doshi:
> ---
> fftools/opt_common.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/fftools/opt_common.c b/fftools/opt_common.c
> index 317e8458c1..2ac3fd4fb3 100644
> --- a/fftools/opt_common.c
> +++ b/fftools/opt_common.c
> @@ -1330,6 +1330,11 @@ int opt_loglevel(void *optctx, const char *opt, const char *arg)
> "Possible levels are numbers or:\n", arg);
> for (i = 0; i < FF_ARRAY_ELEMS(log_levels); i++)
> av_log(NULL, AV_LOG_FATAL, "\"%s\"\n", log_levels[i].name);
> + av_log(NULL, AV_LOG_FATAL, "Possible flags are:\n");
> + av_log(NULL, AV_LOG_FATAL, "\"repeat\"\n");
> + av_log(NULL, AV_LOG_FATAL, "\"level\"\n");
> + av_log(NULL, AV_LOG_FATAL, "\"time\"\n");
> + av_log(NULL, AV_LOG_FATAL, "\"datetime\"\n");
> return AVERROR(EINVAL);
> }
>
This would all fit into one line.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] fftools: notify user of flags upon loglevel parse failure
2025-02-21 8:51 ` Andreas Rheinhardt
@ 2025-02-21 9:53 ` Gyan Doshi
2025-02-21 11:04 ` Andreas Rheinhardt
0 siblings, 1 reply; 5+ messages in thread
From: Gyan Doshi @ 2025-02-21 9:53 UTC (permalink / raw)
To: ffmpeg-devel
On 2025-02-21 02:21 pm, Andreas Rheinhardt wrote:
> Gyan Doshi:
>> ---
>> fftools/opt_common.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/fftools/opt_common.c b/fftools/opt_common.c
>> index 317e8458c1..2ac3fd4fb3 100644
>> --- a/fftools/opt_common.c
>> +++ b/fftools/opt_common.c
>> @@ -1330,6 +1330,11 @@ int opt_loglevel(void *optctx, const char *opt, const char *arg)
>> "Possible levels are numbers or:\n", arg);
>> for (i = 0; i < FF_ARRAY_ELEMS(log_levels); i++)
>> av_log(NULL, AV_LOG_FATAL, "\"%s\"\n", log_levels[i].name);
>> + av_log(NULL, AV_LOG_FATAL, "Possible flags are:\n");
>> + av_log(NULL, AV_LOG_FATAL, "\"repeat\"\n");
>> + av_log(NULL, AV_LOG_FATAL, "\"level\"\n");
>> + av_log(NULL, AV_LOG_FATAL, "\"time\"\n");
>> + av_log(NULL, AV_LOG_FATAL, "\"datetime\"\n");
>> return AVERROR(EINVAL);
>> }
>>
> This would all fit into one line.
Do you mean a single log call, or also printed on one line?
If the former, the remaining values will be misaligned with the first one.
If the latter, it's prettier with one value per line, just like the log
level values printed just above.
Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] fftools: notify user of flags upon loglevel parse failure
2025-02-21 9:53 ` Gyan Doshi
@ 2025-02-21 11:04 ` Andreas Rheinhardt
2025-02-21 12:04 ` Gyan Doshi
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Rheinhardt @ 2025-02-21 11:04 UTC (permalink / raw)
To: ffmpeg-devel
Gyan Doshi:
>
>
> On 2025-02-21 02:21 pm, Andreas Rheinhardt wrote:
>> Gyan Doshi:
>>> ---
>>> fftools/opt_common.c | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/fftools/opt_common.c b/fftools/opt_common.c
>>> index 317e8458c1..2ac3fd4fb3 100644
>>> --- a/fftools/opt_common.c
>>> +++ b/fftools/opt_common.c
>>> @@ -1330,6 +1330,11 @@ int opt_loglevel(void *optctx, const char
>>> *opt, const char *arg)
>>> "Possible levels are numbers or:\n", arg);
>>> for (i = 0; i < FF_ARRAY_ELEMS(log_levels); i++)
>>> av_log(NULL, AV_LOG_FATAL, "\"%s\"\n",
>>> log_levels[i].name);
>>> + av_log(NULL, AV_LOG_FATAL, "Possible flags are:\n");
>>> + av_log(NULL, AV_LOG_FATAL, "\"repeat\"\n");
>>> + av_log(NULL, AV_LOG_FATAL, "\"level\"\n");
>>> + av_log(NULL, AV_LOG_FATAL, "\"time\"\n");
>>> + av_log(NULL, AV_LOG_FATAL, "\"datetime\"\n");
>>> return AVERROR(EINVAL);
>>> }
>>>
>> This would all fit into one line.
>
> Do you mean a single log call, or also printed on one line?
> If the former, the remaining values will be misaligned with the first one.
> If the latter, it's prettier with one value per line, just like the log
> level values printed just above.
I meant the latter. And I actually prefer the more compact form
"repeat", "level", "time", "datetime" to the one-value-per-line form.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] fftools: notify user of flags upon loglevel parse failure
2025-02-21 11:04 ` Andreas Rheinhardt
@ 2025-02-21 12:04 ` Gyan Doshi
0 siblings, 0 replies; 5+ messages in thread
From: Gyan Doshi @ 2025-02-21 12:04 UTC (permalink / raw)
To: ffmpeg-devel
On 2025-02-21 04:34 pm, Andreas Rheinhardt wrote:
> Gyan Doshi:
>>
>> On 2025-02-21 02:21 pm, Andreas Rheinhardt wrote:
>>> Gyan Doshi:
>>>> ---
>>>> fftools/opt_common.c | 5 +++++
>>>> 1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/fftools/opt_common.c b/fftools/opt_common.c
>>>> index 317e8458c1..2ac3fd4fb3 100644
>>>> --- a/fftools/opt_common.c
>>>> +++ b/fftools/opt_common.c
>>>> @@ -1330,6 +1330,11 @@ int opt_loglevel(void *optctx, const char
>>>> *opt, const char *arg)
>>>> "Possible levels are numbers or:\n", arg);
>>>> for (i = 0; i < FF_ARRAY_ELEMS(log_levels); i++)
>>>> av_log(NULL, AV_LOG_FATAL, "\"%s\"\n",
>>>> log_levels[i].name);
>>>> + av_log(NULL, AV_LOG_FATAL, "Possible flags are:\n");
>>>> + av_log(NULL, AV_LOG_FATAL, "\"repeat\"\n");
>>>> + av_log(NULL, AV_LOG_FATAL, "\"level\"\n");
>>>> + av_log(NULL, AV_LOG_FATAL, "\"time\"\n");
>>>> + av_log(NULL, AV_LOG_FATAL, "\"datetime\"\n");
>>>> return AVERROR(EINVAL);
>>>> }
>>>>
>>> This would all fit into one line.
>> Do you mean a single log call, or also printed on one line?
>> If the former, the remaining values will be misaligned with the first one.
>> If the latter, it's prettier with one value per line, just like the log
>> level values printed just above.
> I meant the latter. And I actually prefer the more compact form
> "repeat", "level", "time", "datetime" to the one-value-per-line form.
I think the per-line approach is visually clearer, so I'd like to keep
it as it is. You can submit a patch to reformat it if you like.
Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-02-21 12:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-20 10:06 [FFmpeg-devel] [PATCH] fftools: notify user of flags upon loglevel parse failure Gyan Doshi
2025-02-21 8:51 ` Andreas Rheinhardt
2025-02-21 9:53 ` Gyan Doshi
2025-02-21 11:04 ` Andreas Rheinhardt
2025-02-21 12:04 ` Gyan Doshi
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git