From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B49A54D331 for ; Wed, 19 Feb 2025 20:46:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4BF0D68C41B; Wed, 19 Feb 2025 22:46:06 +0200 (EET) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 94AC268C23D for ; Wed, 19 Feb 2025 22:45:54 +0200 (EET) Received: from haasn.dev (unknown [10.30.1.1]) by haasn.dev (Postfix) with ESMTP id 622E7425D8; Wed, 19 Feb 2025 21:45:54 +0100 (CET) From: Niklas Haas To: ffmpeg-devel@ffmpeg.org Date: Wed, 19 Feb 2025 21:45:41 +0100 Message-ID: <20250219204550.2826561-5-ffmpeg@haasn.xyz> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20250219204550.2826561-1-ffmpeg@haasn.xyz> References: <20250219204550.2826561-1-ffmpeg@haasn.xyz> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 05/12] avcodec/encode: enforce alpha mode compatibility at encode time X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Niklas Haas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Niklas Haas Error out if trying to encode frames with an incompatible alpha mode. --- libavcodec/encode.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/libavcodec/encode.c b/libavcodec/encode.c index cd10dcf3cd..4e05932e9f 100644 --- a/libavcodec/encode.c +++ b/libavcodec/encode.c @@ -602,6 +602,33 @@ static int encode_preinit_video(AVCodecContext *avctx) avctx->color_range = AVCOL_RANGE_JPEG; } + if (pixdesc->flags & AV_PIX_FMT_FLAG_ALPHA) { + const enum AVAlphaMode *alpha_modes; + int num_alpha_modes; + ret = avcodec_get_supported_config(avctx, NULL, AV_CODEC_CONFIG_ALPHA_MODE, + 0, (const void **) &alpha_modes, &num_alpha_modes); + if (ret < 0) + return ret; + + if (avctx->alpha_mode != AVALPHA_MODE_UNSPECIFIED && alpha_modes) { + for (i = 0; i < num_alpha_modes; i++) { + if (avctx->alpha_mode == alpha_modes[i]) + break; + } + if (i == num_alpha_modes) { + av_log(avctx, AV_LOG_ERROR, + "Specified alpha mode '%s' is not supported by the %s encoder.\n", + av_alpha_mode_name(avctx->alpha_mode), c->name); + av_log(avctx, AV_LOG_ERROR, "Supported alpha modes:\n"); + for (int p = 0; alpha_modes[p] != AVALPHA_MODE_UNSPECIFIED; p++) { + av_log(avctx, AV_LOG_ERROR, " %s\n", + av_alpha_mode_name(alpha_modes[p])); + } + return AVERROR(EINVAL); + } + } + } + if ( avctx->bits_per_raw_sample < 0 || (avctx->bits_per_raw_sample > 8 && pixdesc->comp[0].depth <= 8)) { av_log(avctx, AV_LOG_WARNING, "Specified bit depth %d not possible with the specified pixel formats depth %d\n", -- 2.47.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".