From: Romain Beauxis <romain.beauxis@gmail.com> To: ffmpeg-devel@ffmpeg.org Cc: Romain Beauxis <romain.beauxis@gmail.com> Subject: [FFmpeg-devel] [PATCH v6 1/9] libavcodec/decode.c: Add generic metadata injection using AV_PKT_DATA_METADATA_UPDATE Date: Tue, 18 Feb 2025 23:24:37 -0600 Message-ID: <20250219052445.86383-2-romain.beauxis@gmail.com> (raw) In-Reply-To: <20250219052445.86383-1-romain.beauxis@gmail.com> --- libavcodec/decode.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index cac7e620d2..96e2f0ce95 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c @@ -97,6 +97,8 @@ typedef struct DecodeContext { int lcevc_frame; int width; int height; + + AVDictionary *pending_metadata; } DecodeContext; static DecodeContext *decode_ctx(AVCodecInternal *avci) @@ -729,6 +731,8 @@ int attribute_align_arg avcodec_send_packet(AVCodecContext *avctx, const AVPacke { AVCodecInternal *avci = avctx->internal; DecodeContext *dc = decode_ctx(avci); + const uint8_t *side_metadata; + size_t size; int ret; if (!avcodec_is_open(avctx) || !av_codec_is_decoder(avctx->codec)) @@ -746,6 +750,14 @@ int attribute_align_arg avcodec_send_packet(AVCodecContext *avctx, const AVPacke ret = av_packet_ref(avci->buffer_pkt, avpkt); if (ret < 0) return ret; + + side_metadata = av_packet_get_side_data(avpkt, AV_PKT_DATA_METADATA_UPDATE, &size); + if (side_metadata) { + av_dict_free(&dc->pending_metadata); + ret = av_packet_unpack_dictionary(side_metadata, size, &dc->pending_metadata); + if (ret < 0) + return ret; + } } else dc->draining_started = 1; @@ -815,6 +827,7 @@ fail: int ff_decode_receive_frame(AVCodecContext *avctx, AVFrame *frame) { AVCodecInternal *avci = avctx->internal; + DecodeContext *dc = decode_ctx(avci); int ret; if (!avcodec_is_open(avctx) || !av_codec_is_decoder(avctx->codec)) @@ -887,6 +900,12 @@ int ff_decode_receive_frame(AVCodecContext *avctx, AVFrame *frame) } } #endif + + if (dc->pending_metadata) { + av_dict_copy(&frame->metadata, dc->pending_metadata, AV_DICT_APPEND); + av_dict_free(&dc->pending_metadata); + } + return 0; fail: av_frame_unref(frame); @@ -2314,4 +2333,5 @@ void ff_decode_internal_uninit(AVCodecContext *avctx) DecodeContext *dc = decode_ctx(avci); av_refstruct_unref(&dc->lcevc); + av_dict_free(&dc->pending_metadata); } -- 2.39.5 (Apple Git-154) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-02-19 5:25 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-02-19 5:24 [FFmpeg-devel] [PATCH v6 0/9] Properly decode ogg metadata in ogg/{vorbis, flac, opus} chained bitstreams Romain Beauxis 2025-02-19 5:24 ` Romain Beauxis [this message] 2025-02-19 5:24 ` [FFmpeg-devel] [PATCH v6 2/9] tests: Add stream dump test API util Romain Beauxis 2025-02-19 5:24 ` [FFmpeg-devel] [PATCH v6 3/9] libavformat/oggparsevorbis.c: Don't append new metadata Romain Beauxis 2025-02-19 5:24 ` [FFmpeg-devel] [PATCH v6 4/9] tests: Add chained ogg/vorbis stream dump test Romain Beauxis 2025-02-19 17:53 ` Romain Beauxis 2025-02-19 5:24 ` [FFmpeg-devel] [PATCH v6 5/9] libavformat/oggdec.h, libavformat/oggparsevorbis.c: Factor out vorbis metadata update mechanism Romain Beauxis 2025-02-19 5:24 ` [FFmpeg-devel] [PATCH v6 6/9] libavformat/oggparseflac.c: Parse ogg/flac comments in new ogg packets, add them to ogg stream new_metadata Romain Beauxis 2025-02-19 5:24 ` [FFmpeg-devel] [PATCH v6 7/9] tests: Add chained ogg/flac stream dump test Romain Beauxis 2025-02-21 11:01 ` Michael Niedermayer 2025-02-21 15:40 ` Romain Beauxis 2025-02-19 5:24 ` [FFmpeg-devel] [PATCH v6 8/9] libavformat/oggparseopus.c: Parse comments from secondary chained streams header packet Romain Beauxis 2025-02-19 5:24 ` [FFmpeg-devel] [PATCH v6 9/9] tests: Add chained ogg/opus stream dump test Romain Beauxis 2025-02-19 18:17 ` [FFmpeg-devel] [PATCH v6 0/9] Properly decode ogg metadata in ogg/{vorbis, flac, opus} chained bitstreams Lynne 2025-02-19 18:57 ` Romain Beauxis 2025-02-21 15:41 ` Romain Beauxis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20250219052445.86383-2-romain.beauxis@gmail.com \ --to=romain.beauxis@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git