Re: [FFmpeg-devel] [PATCH v2 2/2] libavformat/rtsp: Free memory allocated for temporary variables while processing sdp info

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1174 bytes --]

On Mon, Feb 17, 2025 at 01:41:30PM -0500, Rashad Tatum wrote:
> ---
>  libavformat/rtsp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
> index 0c65f8d1a4..da733938bc 100644
> --- a/libavformat/rtsp.c
> +++ b/libavformat/rtsp.c
> @@ -478,6 +478,7 @@ static void sdp_parse_line(AVFormatContext *s, SDPParseState *s1,
>                                                sdp_ip_str);
>  
>          }
> +        av_freep(sdp_ip_str);
>          break;
>      case 's':
>          av_dict_set(&s->metadata, "title", p, 0);
> @@ -702,6 +703,7 @@ static void sdp_parse_line(AVFormatContext *s, SDPParseState *s1,
>                      }
>                  }
>              }
> +            av_freep(dest_addr);
>          } else {
>              if (rt->server_type == RTSP_SERVER_WMS)
>                  ff_wms_parse_sdp_a_line(s, p);

Segmentation fault (core dumped)

av_freep takes a pointer to a pointer


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Give a rich man 100$ and he will turn it into 1000$.
Give a poor man 1000$ and he will spend it.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".