From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id A63E54D1F1 for ; Tue, 18 Feb 2025 12:50:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0E99C68C08C; Tue, 18 Feb 2025 14:50:49 +0200 (EET) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CF46368BE12 for ; Tue, 18 Feb 2025 14:50:41 +0200 (EET) Received: from haasn.dev (unknown [10.30.1.1]) by haasn.dev (Postfix) with ESMTP id 9B1FF403BC; Tue, 18 Feb 2025 13:50:41 +0100 (CET) Date: Tue, 18 Feb 2025 13:50:41 +0100 Message-ID: <20250218135041.GB95668@haasn.xyz> From: Niklas Haas To: ffmpeg-devel@ffmpeg.org In-Reply-To: <20250218124603.95398-1-ffmpeg@haasn.xyz> References: <20250218124603.95398-1-ffmpeg@haasn.xyz> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH v2 1/4] avfilter/graphdump: implement options parsing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Niklas Haas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 18 Feb 2025 13:46:00 +0100 Niklas Haas wrote: > From: Niklas Haas > > And use it to make the output format configurable. > > I also added a "none" option to explicitly disable the behavior (in case a > previous command line argument was used to enable it). This has the added > benefit of giving the default "pretty" format the ID 1, allowing `-dumpgraph 1` > to continue working as expected. Should address all of the issues brought up in the previous review. One difference in this implementation is that we now print buffer/buffersink filters as well, because I couldn't justify omitting them from an implementation that has nothing to do with ffmpeg.c. This does unfortunately mean that the output can't *directly* be reused as an input to -filter_complex without first removing the buffer* entries. In theory we could add an option to explicitly drop them, but I'm not sold on the idea. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".