From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 6AA844D1F1 for ; Tue, 18 Feb 2025 13:09:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4494568C176; Tue, 18 Feb 2025 15:08:45 +0200 (EET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E59AC68C0FC for ; Tue, 18 Feb 2025 15:08:36 +0200 (EET) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-220c2a87378so75532875ad.1 for ; Tue, 18 Feb 2025 05:08:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739884115; x=1740488915; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=XWP3a5MOm5blOD1ZnNxShvNGLVO5HhHOUCurif7UrYE=; b=ZVA0sC67z4XL/WqQKk+bM2UzMMCPXr+YofEZ5oGVd7fOxCzlUBrYSaEcBBBMG7JoiP 88vv2iJ2rIqypZRX00IaZpaUV4liFWgs6pumhEV1VvdPCy4BFCsPh2vLC8P6jIheR0ZI c8rpQvnb5y8lfKLQG1MyqeM7Hc+q95A7P6bZzHqkezQ6AZ7zxpmz6pZHb5lyv8Mseu4c UttMGml2Vz65xV4lwEYGI5jwaNuD8tiESfom1izfYFFyIs0+UhqoHrmtj2zKE33krocH ahOR4pu+NNsZlJsarDTc4J1+swblurwHG2I/KWUcSV+952yWDmrJELpiDVqeJg86AEPq nRZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739884115; x=1740488915; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XWP3a5MOm5blOD1ZnNxShvNGLVO5HhHOUCurif7UrYE=; b=gv+EIuy154GeinLDrFDoPHadQe4beLl27Cj1yzciGQ3bMiuhT5M3P6zv0hxYr/6KYE fHFWSy12fNBpUgwGwtM0vfSzbK55zsM29gUA6XnakPZuqk63XDAN61jGjtwuQis/f5Bm 0Wg4qYnY6nclo+8/DIU8l1nO0cCkmbVPCd7OZptOXOXun4kXlpP8YDnilfjXigYmy+8Y 1rPBiSkpGFoclj5bm5nvcok3QtFIDRVbHRGVWG3k/cZ/7KswZ9kXrjSFPFabGRWANgkZ TE9q4jRGXzteYRjxiYlq4ry4yvOAkthGKFQ/h3gNEMxcxyfodTgFR9k3FyjyjZxdyrhV tzRA== X-Gm-Message-State: AOJu0Yw2d5dG/+DtpCL0oGRsgU+S/tlbW2rYyyv1fXl8YVRsW3isWYkq AJmRpSmE4Qc4PX/EKHiEwcXtcfOnleXs65fGIFjGZ1dv0W6n3CzakLpMmBii X-Gm-Gg: ASbGnctzYTwUm1tBYG2zyKBuz2ZbKmpVaWTwfIrA8GoYxOEEdnfPS2CoGDwaArGrkIW dIoduC3DCoqEJYmhrjN93OSRpcKKseli9aHhqRLNnxnEw/D3dpifb71jlIAnhJh14lQji5VY+rr sv8ReB2MQLZGGVNXcdh2Y/H0xduJG9CZVKajGV4T5rOudnzA+j1qyl3hfrEs5ovnsma3BSHBPTH M8UvcMOFXkrdLvZ7DZEJDdQtIefVUkg0MTagRrhdjJ0WlimcbwcSASnmoKWVgmF3EorPpa4cn3y /a39DDLEnBMVovoOf88Zf/J2nLGkxg== X-Google-Smtp-Source: AGHT+IHtAcbOEXXcKbO9M+5A9mgrLsQ6KCrfXYdVVpIyxcjoxF9ahSVsNkewWp23wgU4+2bxUYraCw== X-Received: by 2002:a17:903:2341:b0:21f:89e5:2715 with SMTP id d9443c01a7336-22104056b09mr225855095ad.19.1739884114788; Tue, 18 Feb 2025 05:08:34 -0800 (PST) Received: from localhost.localdomain ([2800:2121:b040:c:a0a7:974:71c7:ca89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d556d66fsm89178635ad.180.2025.02.18.05.08.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 05:08:34 -0800 (PST) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Tue, 18 Feb 2025 10:08:06 -0300 Message-ID: <20250218130813.74-4-jamrial@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250218130813.74-1-jamrial@gmail.com> References: <20250218130813.74-1-jamrial@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 04/11] avcodec/libx264: add support for encoder reconfiguration X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Signed-off-by: James Almer --- libavcodec/libx264.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index f5517ad080..d2adfa7bc5 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -769,6 +769,32 @@ static void X264_flush(AVCodecContext *avctx) x4->sei_size = -x4->sei_size; } +static av_cold int X264_reconf(AVCodecContext *avctx, AVDictionary **dict) +{ + static const AVOption global_opts[] = { + { "aspect", "sample aspect ratio", offsetof(AVCodecContext, sample_aspect_ratio), AV_OPT_TYPE_RATIONAL, {.dbl = 0}, 0, 10, AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM}, + { "sar", "sample aspect ratio", offsetof(AVCodecContext, sample_aspect_ratio), AV_OPT_TYPE_RATIONAL, {.dbl = 0}, 0, 10, AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM}, + { "bufsize", "set ratecontrol buffer size (in bits)", offsetof(AVCodecContext, rc_buffer_size), AV_OPT_TYPE_INT, {.i64 = 0 }, INT_MIN, INT_MAX, AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM}, + { "b", "set bitrate (in bits/s)", offsetof(AVCodecContext, bit_rate), AV_OPT_TYPE_INT64, {.i64 = 0 }, 0, INT64_MAX, AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM}, + { NULL }, + }; + static const AVOption private_opts[] = { + { "crf", "Select the quality for constant quality mode", offsetof(X264Context, crf), AV_OPT_TYPE_FLOAT, {.dbl = -1 }, -1, FLT_MAX, AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM }, + { "crf_max", "In CRF mode, prevents VBV from lowering quality beyond this point.", offsetof(X264Context, crf_max), AV_OPT_TYPE_FLOAT, {.dbl = -1 }, -1, FLT_MAX, AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM }, + { "qp", "Constant quantization parameter rate control method", offsetof(X264Context, cqp), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, INT_MAX, AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM }, + { NULL }, + }; + int ret; + + ret = ff_encode_reconf_parse_dict(avctx, global_opts, private_opts, dict); + if (ret < 0) + return ret; + + reconfig_encoder(avctx); + + return 0; +} + static av_cold int X264_close(AVCodecContext *avctx) { X264Context *x4 = avctx->priv_data; @@ -1634,6 +1660,7 @@ const FFCodec ff_libx264_encoder = { AV_CODEC_CAP_OTHER_THREADS | AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE | AV_CODEC_CAP_ENCODER_FLUSH | + AV_CODEC_CAP_RECONF | AV_CODEC_CAP_ENCODER_RECON_FRAME, .p.priv_class = &x264_class, .p.wrapper_name = "libx264", @@ -1641,6 +1668,7 @@ const FFCodec ff_libx264_encoder = { .init = X264_init, FF_CODEC_ENCODE_CB(X264_frame), .flush = X264_flush, + .reconf = X264_reconf, .close = X264_close, .defaults = x264_defaults, .p.pix_fmts = pix_fmts_all, -- 2.48.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".