From: Lynne <dev@lynne.ee>
To: ffmpeg-devel@ffmpeg.org
Cc: Lynne <dev@lynne.ee>
Subject: [FFmpeg-devel] [PATCH 07/11] gblur_vulkan: port to imageLoad()
Date: Mon, 17 Feb 2025 19:31:17 +0100
Message-ID: <20250217183125.57656-7-dev@lynne.ee> (raw)
In-Reply-To: <20250217183125.57656-1-dev@lynne.ee>
---
libavfilter/vf_gblur_vulkan.c | 20 ++++++++------------
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/libavfilter/vf_gblur_vulkan.c b/libavfilter/vf_gblur_vulkan.c
index 58251c4a17..101c8ffd8c 100644
--- a/libavfilter/vf_gblur_vulkan.c
+++ b/libavfilter/vf_gblur_vulkan.c
@@ -53,11 +53,11 @@ typedef struct GBlurVulkanContext {
static const char gblur_func[] = {
C(0, void gblur(const ivec2 pos, const int index) )
C(0, { )
- C(1, vec4 sum = texture(input_images[index], pos) * kernel[0]; )
+ C(1, vec4 sum = imageLoad(input_images[index], pos) * kernel[0]; )
C(0, )
C(1, for(int i = 1; i < kernel.length(); i++) { )
- C(2, sum += texture(input_images[index], pos + OFFSET) * kernel[i]; )
- C(2, sum += texture(input_images[index], pos - OFFSET) * kernel[i]; )
+ C(2, sum += imageLoad(input_images[index], pos + OFFSET) * kernel[i]; )
+ C(2, sum += imageLoad(input_images[index], pos - OFFSET) * kernel[i]; )
C(1, } )
C(0, )
C(1, imageStore(output_images[index], pos, sum); )
@@ -163,7 +163,7 @@ static int init_gblur_pipeline(GBlurVulkanContext *s,
if (s->planes & (1 << i)) {
GLSLF(1, gblur(pos, %i); ,i);
} else {
- GLSLF(1, vec4 res = texture(input_images[%i], pos); ,i);
+ GLSLF(1, vec4 res = imageLoad(input_images[%i], pos); ,i);
GLSLF(1, imageStore(output_images[%i], pos, res); ,i);
}
}
@@ -220,16 +220,16 @@ static av_cold int init_filter(AVFilterContext *ctx, AVFrame *in)
}
RET(ff_vk_exec_pool_init(vkctx, s->qf, &s->e, s->qf->num*4, 0, 0, 0, NULL));
- RET(ff_vk_init_sampler(vkctx, &s->sampler, 1, VK_FILTER_LINEAR));
desc = (FFVulkanDescriptorSetBinding []) {
{
.name = "input_images",
- .type = VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
+ .type = VK_DESCRIPTOR_TYPE_STORAGE_IMAGE,
+ .mem_layout = ff_vk_shader_rep_fmt(s->vkctx.input_format, FF_VK_REP_FLOAT),
+ .mem_quali = "readonly",
.dimensions = 2,
.elems = planes,
.stages = VK_SHADER_STAGE_COMPUTE_BIT,
- .samplers = DUP_SAMPLER(s->sampler),
},
{
.name = "output_images",
@@ -293,10 +293,6 @@ static av_cold void gblur_vulkan_uninit(AVFilterContext *avctx)
ff_vk_free_buf(vkctx, &s->params_hor);
ff_vk_free_buf(vkctx, &s->params_ver);
- if (s->sampler)
- vk->DestroySampler(vkctx->hwctx->act_dev, s->sampler,
- vkctx->hwctx->alloc);
-
ff_vk_uninit(&s->vkctx);
s->initialized = 0;
@@ -327,7 +323,7 @@ static int gblur_vulkan_filter_frame(AVFilterLink *link, AVFrame *in)
RET(ff_vk_filter_process_2pass(&s->vkctx, &s->e,
(FFVulkanShader *[2]){ &s->shd_hor, &s->shd_ver },
- out, tmp, in, s->sampler, NULL, 0));
+ out, tmp, in, VK_NULL_HANDLE, NULL, 0));
err = av_frame_copy_props(out, in);
if (err < 0)
--
2.47.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-02-17 18:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 18:31 [FFmpeg-devel] [PATCH 01/11] vulkan_filter: use GENERAL image layout when no sampler is given Lynne
2025-02-17 18:31 ` [FFmpeg-devel] [PATCH 02/11] bwdif_vulkan: convert to storage images Lynne
2025-02-17 18:31 ` [FFmpeg-devel] [PATCH 03/11] nlmeans_vulkan: switch to imageLoad() Lynne
2025-02-17 18:31 ` [FFmpeg-devel] [PATCH 04/11] avgblur_vulkan: port " Lynne
2025-02-17 18:31 ` [FFmpeg-devel] [PATCH 05/11] chromaber_vulkan: fix use of texture() Lynne
2025-02-17 20:03 ` Lynne
2025-02-17 18:31 ` [FFmpeg-devel] [PATCH 06/11] flip_vulkan: port to imageLoad() Lynne
2025-02-17 18:31 ` Lynne [this message]
2025-02-17 18:31 ` [FFmpeg-devel] [PATCH 08/11] gblur_vulkan: " Lynne
2025-02-17 19:49 ` Lynne
2025-02-17 18:31 ` [FFmpeg-devel] [PATCH 09/11] transpose_vulkan: " Lynne
2025-02-17 18:31 ` [FFmpeg-devel] [PATCH 10/11] blend_vulkan: " Lynne
2025-02-17 18:32 ` [FFmpeg-devel] [PATCH 11/11] overlay_vulkan: " Lynne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250217183125.57656-7-dev@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git