Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] libavformat/rtsp: Make source specific multicast work for rtsp streams
Date: Mon, 17 Feb 2025 09:46:18 +0100
Message-ID: <20250217084618.GI4991@pb2> (raw)
In-Reply-To: <4bc51275-6577-433d-ac02-fb034d17142f@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 2071 bytes --]

On Fri, Feb 14, 2025 at 12:08:24PM -0500, Rashad Tatum wrote:
> by first changing the RTSPSource to track the destination address
> obtained from the source filter. For each RTSPStream, only add the source
> filter from the sdp if sdp_ip string matches source-filter's destination
> address.
> 
> Before issuing the setup request, change the lower_transport to
> multicast if the sdp_ip is a multicast address.
> 
> Change the multicast case to append sources (from the source-filter) to
> the rtp url to make the source specific multicast join work.
> 
> Signed-off-by: Rashad Tatum <tatum.rashad@gmail.com>
> ---
>  libavformat/rtsp.c | 88 +++++++++++++++++++++++++++++++---------------
>  libavformat/rtsp.h |  3 +-
>  2 files changed, 62 insertions(+), 29 deletions(-)
> 
> diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
> index 5ea471b40c..0c65f8d1a4 100644
> --- a/libavformat/rtsp.c
> +++ b/libavformat/rtsp.c
> @@ -389,16 +389,18 @@ typedef struct SDPParseState {
>  } SDPParseState;
>   static void copy_default_source_addrs(struct RTSPSource **addrs, int
> count,
> -                                      struct RTSPSource ***dest, int
> *dest_count)
> +                                      struct RTSPSource ***dest, int
> *dest_count, const char* sdp_ip_str)

Applying: libavformat/rtsp: Make source specific multicast work for rtsp streams
error: patch fragment without header at line 41: @@ -448,6 +450,8 @@ static void sdp_parse_line(AVFormatContext *s, SDPParseState *s1,
error: could not build fake ancestor
Patch failed at 0001 libavformat/rtsp: Make source specific multicast work for rtsp streams

This patch is corrupted by line breaks
Check your editors line/word wraping settings
OR
attach the patch
OR
use git send-email

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2025-02-17  8:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-14 17:08 Rashad Tatum
2025-02-14 17:09 ` [FFmpeg-devel] [PATCH 2/2] libavformat/rtsp: Free memory allocated for temporary variables while processing sdp info Rashad Tatum
2025-02-17  8:46 ` Michael Niedermayer [this message]
2025-02-17 15:43   ` [FFmpeg-devel] [PATCH 1/2] libavformat/rtsp: Make source specific multicast work for rtsp streams Rashad Tatum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250217084618.GI4991@pb2 \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git