From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5CF804C8FA for ; Sun, 16 Feb 2025 00:17:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 13D4568BDA1; Sun, 16 Feb 2025 02:17:48 +0200 (EET) Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 483F168B860 for ; Sun, 16 Feb 2025 02:17:41 +0200 (EET) Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-6e670d29644so5943846d6.3 for ; Sat, 15 Feb 2025 16:17:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739665060; x=1740269860; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=INXarl6nxUdTtJx2/hWezrMeY2Ez3JciALk5yUa7/+c=; b=TPwjqRsYgRt8fBhsdYipShAryflyLpY/h7wOedYlrVF4z21UFLfEZNOHVZcb7cTDTP GPnxNBaJoXOm60/kP/rx6jnivVfoHyHCTHHyQctMDtb9BL5d6HxqAEPVm8PEVvk4v+Jk KARMxWG4zjF1a+X3G0k0gCGfce711s3a9c8u3buGInqqDcD564MroyA4Z/LFl30ZNIzF l4rENoxyYKEQB++Ej7LRxxWnVt9/y0xQNHBsl3+ClvV/LUUW2riuHp+t6SqPsCvP4sL/ B+FZXJn7RXsveiuAK8+fHqDaiQxCFApk+ipS0ghAmx2eQNN0priIvpTi5qLIl7v7bEg4 yZNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739665060; x=1740269860; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=INXarl6nxUdTtJx2/hWezrMeY2Ez3JciALk5yUa7/+c=; b=SftkphgQteD4Ro3DHosbCUK31mB17vhNbhGD73bfIsZCSZ2HpecnPP251uiY31Vcpj yb+nA0zn/pd1SE8P+TNQPFzM1SE0DDMsP177cDNGGWhbPJfmJVEXVi6GdTZiCWdx5WlK M2MMDMR3NKrjuCS0axVYkuLuRZpSLSQqHXrEwQVRCqgz/Nar5M4CAgOlbkwIS7A/mSh6 Xu01GIbJSBAkVXqJSIhdVSxbKTM5MX5WdvOtrMeQ4uDBtlqED2M/qmQuSz0dF6GEIkkK OaP5Kcm1ksInCoQsD+RUbEZrygPdhPY1gYy70mBiuKSmVpkNrUESiz96tk4rAJ9TuNSw NtLQ== X-Gm-Message-State: AOJu0YxWxhCco1PYTOvDqc5mqkHa03BHx4f9YpX+GEP9B7OobItSnoYN jfjyQ1eLkLTqgQnyd4fcibLDQ8x1O4M7+uwGp11FmPOGqrMEN4L8+i8Wsw== X-Gm-Gg: ASbGncvU41esJcStFqkyTuIIYI5a+eTw94uDxP7MOiXtB8L7w6iYUI7jxp4NkCKfyQ4 vAtg+3wsra3wG8FAdcM+wFacJO/LQb+3PmH5hQDW31hjxKLtLpIsLTlk8WxesSI4S3+qU1TM8Yx ODjsfvfyAEmoBiIUd05gJrk9BILUXTgk29T8JBOrwwh5rKk2NHm+2NAmL0zKz5VBx4FXnQ8f3AP 6ZFA7uaZkILIGfvG7umMnWyqi/SkT3V8vYvReHiSJerlyjt4o9jWb5aQrMj6ZkQkg/jrAPaVh8V vnhj6H41g/bt8y68e9CcZqtQCihmL3yB2p7il3odPeHd+Q== X-Google-Smtp-Source: AGHT+IGWO0TV5+WqZp5o2+fTCeedTbl0yU5fn9y+KrXTSrw1PS8Rt+c1Gj9yat33Z9R9N+7RLohgRA== X-Received: by 2002:a05:6214:20aa:b0:6e4:242b:934 with SMTP id 6a1803df08f44-6e66ccbf2f1mr71789486d6.17.1739665059635; Sat, 15 Feb 2025 16:17:39 -0800 (PST) Received: from localhost.localdomain ([2600:4808:61b3:6500:a4b7:1f4a:ae3a:bc55]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6e65d7791cdsm37077796d6.9.2025.02.15.16.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Feb 2025 16:17:39 -0800 (PST) From: Stone Chen To: ffmpeg-devel@ffmpeg.org Date: Sat, 15 Feb 2025 19:16:50 -0500 Message-ID: <20250216001650.1775-1-chen.stonechen@gmail.com> X-Mailer: git-send-email 2.47.1.windows.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] checkasm/hevc_deblock: adjust RANDCLIP to clip after rng() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: nuomi2021@gmail.com, Stone Chen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Increase chances of generating a strong deblock test case by changing RANDCLIP to generate the random value first before clipping. RANDCLIP(x, diff) attempts to generate a random value such the distance to x is less than diff. This is also clipped to the pixel range. This is done by subtracting diff from x and adding a random value between 0 and 2*diff. However since this occurs after clipping, if e.g. x - diff is negative, then it's possible to exceed the diff. Instead generate the number first and then clip. Signed-off-by: Stone Chen --- tests/checkasm/hevc_deblock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/hevc_deblock.c b/tests/checkasm/hevc_deblock.c index 89dd8a308b..46faf34c2d 100644 --- a/tests/checkasm/hevc_deblock.c +++ b/tests/checkasm/hevc_deblock.c @@ -104,8 +104,8 @@ static void check_deblock_chroma(HEVCDSPContext *h, int bit_depth, int c) else \ *(uint16_t*)(&x) = z; \ } while (0) -#define RANDCLIP(x, diff) av_clip(GET(x) - (diff), 0, \ - (1 << (bit_depth)) - 1) + rnd() % FFMAX(2 * (diff), 1) +#define RANDCLIP(x, diff) av_clip(GET(x) - (diff) + rnd() % FFMAX(2 * (diff), 1), 0, \ + (1 << (bit_depth)) - 1) // NOTE: this function doesn't work 'correctly' in that it won't always choose // strong/strong or weak/weak, in most cases it tends to but will sometimes mix -- 2.47.1.windows.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".