From: James Almer <jamrial@gmail.com> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH v2 2/2] avformat/demux: don't discard empty Theora packets Date: Fri, 14 Feb 2025 00:14:35 -0300 Message-ID: <20250214031435.1557-1-jamrial@gmail.com> (raw) In-Reply-To: <20250213224746.769-2-jamrial@gmail.com> Theora signals "Output last frame again" with an empty packet. Finishes fixing ticket #11451. Signed-off-by: James Almer <jamrial@gmail.com> --- libavformat/demux.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libavformat/demux.c b/libavformat/demux.c index d8ab29431e..0e39346f62 100644 --- a/libavformat/demux.c +++ b/libavformat/demux.c @@ -1173,7 +1173,15 @@ static int parse_packet(AVFormatContext *s, AVPacket *pkt, if (!size && !flush && sti->parser->flags & PARSER_FLAG_COMPLETE_FRAMES) { // preserve 0-size sync packets - compute_pkt_fields(s, st, sti->parser, pkt, AV_NOPTS_VALUE, AV_NOPTS_VALUE); + compute_pkt_fields(s, st, sti->parser, pkt, pkt->dts, pkt->pts); + + // Theora has valid 0-sized packets that need to be output + if (st->codecpar->codec_id == AV_CODEC_ID_THEORA) { + ret = avpriv_packet_list_put(&fci->parse_queue, + pkt, NULL, 0); + if (ret < 0) + goto fail; + } } while (size > 0 || (flush && got_output)) { -- 2.48.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-02-14 3:15 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-02-13 22:47 [FFmpeg-devel] [PATCH 1/2] avformat/oggenc: don't discard empty packets with no side data James Almer 2025-02-13 22:47 ` [FFmpeg-devel] [PATCH 2/2] avformat/demux: don't discard empty Theora packets James Almer 2025-02-14 3:14 ` James Almer [this message] 2025-02-19 3:19 ` [FFmpeg-devel] [PATCH 1/2] avformat/oggenc: don't discard empty packets with no side data James Almer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20250214031435.1557-1-jamrial@gmail.com \ --to=jamrial@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git