From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D347B4CE10 for ; Wed, 12 Feb 2025 22:03:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 57B6668C11A; Thu, 13 Feb 2025 00:03:51 +0200 (EET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D8E0068BF7C for ; Thu, 13 Feb 2025 00:03:44 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 47573442A9 for ; Wed, 12 Feb 2025 22:03:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1739397824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/3RlRyzRT9LGe2mNQC7rRDy4jQrhl3Tqwv6g4RnT8/w=; b=NjzU7SvySjyxlE8t5kAOXfh1MkrsXK5nt6Pjar4Vh+Zy/T3iUFvbFFZGMzKyfFr+ButAmq LoUS/ZZ3uIaaUV2V5MWBosrDbmbTqYAX5hYoYXQ1iGTXctuu8rwY/NFUJcjnw+Mr6PpTp0 39728nAKg/+JPYmZAL2QaEKzjo1fMf3jOsan3t/o4AVyPzuLLL+hzqYrE99s7xWOzhhAjM s2VA7Xd2W+bo+IWDzvs2oKm3QWeEyvtXd48+qQwf/86QgULPmEKFN/OBe9D7nPATF97w64 q2wFCQU89Xty++Dd/FDhSe4iuouO0Tnjl+wr7dzbe8jD6zAPe9ISf7gjo382fA== Date: Wed, 12 Feb 2025 23:03:43 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250212220343.GU4991@pb2> References: <20250206145817.GN4991@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeghedtfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtudenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepudetvdfhudeuudegudefgfehhfevvdfggfffkefhvdfgvdetffdtjeekheetfeehnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 8/8] Make mime-type award a bonus probe score X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1480226073585240727==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1480226073585240727== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1jSLdOP7aw8qJILb" Content-Disposition: inline --1jSLdOP7aw8qJILb Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 12, 2025 at 12:03:37PM +0100, Tomas H=E4rdin wrote: > tor 2025-02-06 klockan 15:58 +0100 skrev Michael Niedermayer: > > Hi Tomas > >=20 > > On Wed, Feb 05, 2025 at 03:24:24PM +0100, Tomas H=E4rdin wrote: > > > Seems reasonable to me and passes FATE > > >=20 > > > /Tomas > >=20 > > > =A0avformat.h=A0=A0 |=A0=A0=A0 2 +- > > > =A0format.c=A0=A0=A0=A0 |=A0=A0=A0 8 ++++---- > > > =A0libopenmpt.c |=A0=A0=A0 2 +- > > > =A03 files changed, 6 insertions(+), 6 deletions(-) > > > 01f04f79202640330d6be91b0215f92f14d1845a=A0 0008-Make-mime-type- > > > award-a-bonus-probe-score.patch > > > From ecc3459990f2871fd907f96fe66362b8fea41bd8 Mon Sep 17 00:00:00 > > > 2001 > > > From: =3D?UTF-8?q?Peter=3D20Zeb=3DC3=3DBChr?=3D > > > Date: Tue, 21 Nov 2023 14:16:49 +0100 > > > Subject: [PATCH 8/8] Make mime-type award a bonus probe score > > >=20 > > > This changes the default behaviour of ffmpeg where content-type > > > headers > > > on an input gives an absolut probe score (of 75) to instead give a > > > bonus > > > score (of 30). This gives the probe a better chance to arrive at > > > the > > > correct format by (hopefully) giving a large enough bonus to push > > > edge > > > cases in the right direction (MPEG-PS vs MP3, I am looking at you) > > > while > > > also not adversly punishing clearer cases (raw ADTS marked as > > > "audio/mpeg" for example). > > >=20 > > > This patch was regression tested against 20 million recent podcast > > > submissions (after content-type propagation was added to > > > original-storage), and 50k Juno vodcasts submissions (dito). No > > > adverse > > > effects observed (but the bonus may still need tweaking if other > > > edge > > > cases are detected in production). > > > --- > > > =A0libavformat/avformat.h=A0=A0 | 2 +- > > > =A0libavformat/format.c=A0=A0=A0=A0 | 8 ++++---- > > > =A0libavformat/libopenmpt.c | 2 +- > > > =A03 files changed, 6 insertions(+), 6 deletions(-) > >=20 > > what is the score ? > > a higher score means more likely but how much more ? > > maybe we should come up with a more formal definition > > like that score is the number of bits of entropy that where checked > > or > > something like that. > > in such a framework, adding 30 for a mime type match would probably > > make sense > >=20 > > without such a framework, adding 30 to a abstract score is hard to > > review > > beyond that, i dont see anything breaking from this but then i > > dont think we have real tests for mime types >=20 > We don't really have tests for the probe scores at all, which is a > problem. Perhaps if we collected some tricky samples we could construct > a test that demands a certain ordering of probe scores for them? For > now scores are tested indirectly by the fact that most tests rely on > correct probing we have tools/probetest probetest [-f ] [ []] >=20 > Also you can't really "formalize" social relations. The reason why > certain files probe as one thing and not another is down to certain > workflows that demand such behavior, which also entails some workflows > being rejected, or at least requiring explicit -f.=20 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Awnsering whenever a program halts or runs forever is On a turing machine, in general impossible (turings halting problem). On any real computer, always possible as a real computer has a finite number of states N, and will either halt in less than N cycles or never halt. --1jSLdOP7aw8qJILb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ60avwAKCRBhHseHBAsP q9cqAJwPkZ4ae/c1vM7c3YalbE4R+XnOhQCfaSc8/bzVJRhHGgtdlUYaIrMifOg= =WgBm -----END PGP SIGNATURE----- --1jSLdOP7aw8qJILb-- --===============1480226073585240727== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1480226073585240727==--