From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 695A34CDCE for ; Wed, 12 Feb 2025 21:55:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 71AA968C0E9; Wed, 12 Feb 2025 23:55:08 +0200 (EET) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D520668BCCB for ; Wed, 12 Feb 2025 23:55:01 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 3A24F44450 for ; Wed, 12 Feb 2025 21:55:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1739397301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JCzpuDTSBmFdg9DdI9vLmputfP75iqB9UWmbbHzyyYA=; b=VssrUQEe1hj28YSPDvqeU86Uv0iQHQapc6QkgmR2YoLarWtPUii/zSGYS1voNsmwNlBzES /+8dUmVrRCEazXdjvO2VWdK/hiUPdH0XAKf0fzmO6pWr5LRQZMBR0Qm7U6RC5ODZBHzw1f jeBbAyAGcxsDORvDtBmFTshBE1k7MC/86VT2ExVX5Y5W5UJ9HfWSixT6GDBGZr2nZKXp8+ qeWLUanuGAk2JuWIJRETV+P+gUQ64abG30935QXqYq+qz+k5mdy9Lw6gsek7/HFB/XnA7L gdD+mosbOCO6x/vDSD+s2cxIW9yVqumJYrTw1ZryC38AysJsQ7k7LZOJnnAuhg== Date: Wed, 12 Feb 2025 22:55:00 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250212215500.GT4991@pb2> References: <1d49ecd046da86394024e1c3407e8ffd88ef23d7.camel@haerdin.se> <20250206150751.GP4991@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeghedtvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdlfedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtudenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepudetvdfhudeuudegudefgfehhfevvdfggfffkefhvdfgvdetffdtjeekheetfeehnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 3/8] libavformat/flacdec: Export samples md5 as metadata X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3640198605993238201==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3640198605993238201== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="b1CT2bB5llCaftrB" Content-Disposition: inline --b1CT2bB5llCaftrB Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Wed, Feb 12, 2025 at 11:56:16AM +0100, Tomas H=E4rdin wrote: > tor 2025-02-06 klockan 16:07 +0100 skrev Michael Niedermayer: > > Hi Tomas > >=20 > > On Wed, Feb 05, 2025 at 03:20:09PM +0100, Tomas H=E4rdin wrote: [...] > > > diff --git a/libavformat/flacdec.c b/libavformat/flacdec.c > > > index 3c317acaee..9f65c25864 100644 > > > --- a/libavformat/flacdec.c > > > +++ b/libavformat/flacdec.c > > > @@ -33,6 +33,7 @@ > > > =A0#include "replaygain.h" > > > =A0 > > > =A0#define SEEKPOINT_SIZE 18 > > > +#define MD5_BYTE_SIZE 16 > > > =A0 > > > =A0typedef struct FLACDecContext { > > > =A0=A0=A0=A0 FFRawDemuxerContext rawctx; > > > @@ -109,6 +110,7 @@ static int flac_read_header(AVFormatContext *s) > > > =A0=A0=A0=A0=A0=A0=A0=A0 if (metadata_type =3D=3D FLAC_METADATA_TYPE_= STREAMINFO) { > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 uint32_t samplerate; > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 uint64_t samples; > > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 char md5hex[MD5_BYTE_SIZE*2+1]; //= hex representation > > > plus null terminator > > > =A0 > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 /* STREAMINFO can only occur onc= e */ > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 if (found_streaminfo) { > > > @@ -133,6 +135,10 @@ static int flac_read_header(AVFormatContext > > > *s) > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 if (samples > 0) > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 st->dura= tion =3D samples; > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 } > > > + > > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ff_data_to_hex(md5hex, st->codecpa= r->extradata+18, > > > MD5_BYTE_SIZE, 1 /* lowercase */); > > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 md5hex[sizeof(md5hex)-1] =3D '\0'; > > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 av_dict_set(&s->metadata, "samples= _md5", md5hex, 0); > >=20 > > I think "samples_md5" should be documented, so that other decoders > > can use > > the same > > i also see a verify_md5() in hevc > > and crc seems frequently used in decoders >=20 > Documented where? doc/metadata.texi doesn't seem like the place for it. > doc/demuxers.texi maybe? honestly, i didnt think about "where", just that it should be documented somewhere thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are best at talking, realize last or never when they are wrong. --b1CT2bB5llCaftrB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ60YswAKCRBhHseHBAsP q8D8AKCaz7AHrQO4Jbtns/ycbGrayzqj3wCcDTjSatEeaTVxuMhLuJPfj/iyVCw= =6JjM -----END PGP SIGNATURE----- --b1CT2bB5llCaftrB-- --===============3640198605993238201== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3640198605993238201==--