From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 089C24CB8F for ; Tue, 11 Feb 2025 18:18:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ACCFA68BE56; Tue, 11 Feb 2025 20:18:42 +0200 (EET) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0615268BB7C for ; Tue, 11 Feb 2025 20:18:35 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 219E743186 for ; Tue, 11 Feb 2025 18:18:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1739297915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mHiaxJbX6e/HVYmVN+ll8IAZidGu2t61I+0xVygRziA=; b=ej+86H/zrqN8OED3VYZ+wsLG+kgt3HQ7yekBJUcFUp6hoKmll6XKq05kA96kpGeOnK5VpG 1/wKdpENE2JDa627fTpxAlfHXb7Ds9nccPqJ+3Z8jairk7rKgLO8OcV76QNIPiVJhDlJq7 q5kpkW6ybbKppxynmNMbEr8/OX8+nzvXQDtqLXwvXP5SNk336yCsEXlfPMUi0eEFBGa3h5 MVcOGIkso+CGzSVxNmNGnv4Lst9jv/7D0KkaKaqVkV8QNb0PDrFBjmQ3eZgGr7PnkeFbOg wGSiiFnfS0jlONGwW9jb3jOiLEfjBtntEaQ4D2errzboOINZcYkKVfep7+mizA== Date: Tue, 11 Feb 2025 19:18:33 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250211181833.GH4991@pb2> References: <20250207164751.2922-1-jamrial@gmail.com> MIME-Version: 1.0 In-Reply-To: <20250207164751.2922-1-jamrial@gmail.com> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdegudejtdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieegkedtjeduffejhfetgeejtdegteetgfegtdfhjefgvefhteegkeejtddvhfevnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avcodec/vorbisdec: don't abort on EOD when decoding residuals X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3212694270119061667==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3212694270119061667== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xw9RTSkVKTChAXBX" Content-Disposition: inline --xw9RTSkVKTChAXBX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi James On Fri, Feb 07, 2025 at 01:47:51PM -0300, James Almer wrote: > Fixes ticket #11427 >=20 > Signed-off-by: James Almer > --- > It may be a good idea to ensure the timeout fuzzer case doesn't regress > after this. >=20 > libavcodec/vorbisdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c > index 218e855f7a..321408723d 100644 > --- a/libavcodec/vorbisdec.c > +++ b/libavcodec/vorbisdec.c > @@ -1470,7 +1470,7 @@ static av_always_inline int vorbis_residue_decode_i= nternal(vorbis_context *vc, > vorbis_codebook codebook =3D vc->codebooks[v= qbook]; > =20 > if (get_bits_left(gb) <=3D 0) > - return AVERROR_INVALIDDATA; > + return 0; This looks suspect For the test sample from #11427 get_bits_left() at this point is -8 that means 8 bits have already been read beyond the buffer. wherever the error is, reading 8 bits beyond is unlikely to be the correct and intended behavior I think the question would be, what created this file and how exactly does libvorbis handle it, does it also read beyond the buffer That is, do we have a encoder or a decoder bug, and what is that bug exactly thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety -- Benjamin Franklin --xw9RTSkVKTChAXBX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ6uUdQAKCRBhHseHBAsP qxVfAKCEJTQzstSulDeUbDMxyEhl1hhYuACbBr3G4uqjDnGS1ZpJxR5qHPwlDD8= =Tt0t -----END PGP SIGNATURE----- --xw9RTSkVKTChAXBX-- --===============3212694270119061667== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3212694270119061667==--