Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Jörg Habenicht via ffmpeg-devel" <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: "Jörg Habenicht" <j.habenicht@gmx.de>
Subject: [FFmpeg-devel] [PATCH v2 0/2] Extend delogo area to a superellipse
Date: Fri,  7 Feb 2025 23:47:31 +0100
Message-ID: <20250207224733.4666-1-j.habenicht@gmx.de> (raw)

Version 2 of the pathset. One test "if (isnan(yf))" was missing.
Corrected in this version


with help from Michael I extended the ellipse area to a superellipse.

The user parameter 'r' has changed to become a float value.
Values 0 < r < 1 the area looks like a four edge star.
Value r = 1 the area get a rhombus.
Values 1 < r < 2 the area is a rhombus with concave sides.
Value r = 2 the area is an ellipse or a circle.
Values 2 < r the area looks like a rectangular with round edges.
Value = 0 (default, unset) the area is rectangular.

Because of the usage of math functions I added more code testing
the return values.

The parameter r=2 to get an ellipse delogo area seems non intuitive
to me. We should add a better description for the users of the
delogo filter.

The patch has been tested with 'make fate-rsync fate' rebased on the
master branch commit 268d0b6527cba1ebac1f44347578617341f85c35
and applies clean to my previous patchset "Patch to create a circular delogo
area"

Please have a look.

best regards
Jörg


Jörg Habenicht (2):
  avfilter/delogo: changed type of parameter 'r' to float
  avfilter/delogo: change delogo round area to superellipse area

 libavfilter/vf_delogo.c | 72 +++++++++++++++++++++++++++++++++--------
 1 file changed, 58 insertions(+), 14 deletions(-)

--
2.45.3

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2025-02-07 22:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-07 22:47 Jörg Habenicht via ffmpeg-devel [this message]
2025-02-07 22:47 ` [FFmpeg-devel] [PATCH v2 1/2] avfilter/delogo: changed type of parameter 'r' to float Jörg Habenicht via ffmpeg-devel
2025-02-07 22:47 ` [FFmpeg-devel] [PATCH v2 2/2] avfilter/delogo: change delogo round area to superellipse area Jörg Habenicht via ffmpeg-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250207224733.4666-1-j.habenicht@gmx.de \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=j.habenicht@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git