From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 15B5A4C3A6 for <ffmpegdev@gitmailbox.com>; Thu, 6 Feb 2025 21:02:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7BD3868B9C9; Thu, 6 Feb 2025 23:02:14 +0200 (EET) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 35A7F68B7A0 for <ffmpeg-devel@ffmpeg.org>; Thu, 6 Feb 2025 23:02:08 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 7DE8544380 for <ffmpeg-devel@ffmpeg.org>; Thu, 6 Feb 2025 21:02:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1738875727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4RWc4qtYBgAXtGWvXbzIoXZJOor4FWlxD4XJdwD5g04=; b=iZWKn/Tnun6RQJaGKaqudoOm8dHvmJ40sDoT6VZHph23Prosqk6AD0RfLvfvnX+pq+U8qj f1/Kc9mqVnH4hd6sM8l24mx3mgYJp9mciwzNEmS9KbVIZ7tnpiie66dTzbqQQFJIEiRYFU u9p6NHP3wUu5bq1d7B0+FhE4c28H7XhizFhZwuuCf5HMn+7htA1AhqBT9aO4rkmkMlzMis 4us6666T7GkD6Vq259qiTVcr4uTrKirEh3UieVHS0I8CRzbQrErzdy8+TU4g4MfBcTg8vS tBzVsff2nR6UIYw7OnAkWcx/nJyB6seagosfTrdD+H5m/dwIrFhhm2LlENgVGA== Date: Thu, 6 Feb 2025 22:02:06 +0100 From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Message-ID: <20250206210206.GZ4991@pb2> References: <20250203052553.429-1-kasper93@gmail.com> MIME-Version: 1.0 In-Reply-To: <20250203052553.429-1-kasper93@gmail.com> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvjeegudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepleekgefgffeiudefjeeuffejudehtddtudeltdehveevvedtieeulefhtdeutdeknecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/mov: fix eof check in mov_read_iinf() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: multipart/mixed; boundary="===============9116207279606530559==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250206210206.GZ4991@pb2/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> --===============9116207279606530559== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JY+SC33kxmVlLmw2" Content-Disposition: inline --JY+SC33kxmVlLmw2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 03, 2025 at 06:25:53AM +0100, Kacper Michaj=C5=82ow wrote: > This fix ensures that the loop stops early on EOF. The issue occurs > because mov_read_infe() performs a version check and skips unsupported > versions. The problem is that seeking within the stream clears the EOF > flag, causing avio_feof() to not function as expected. This is resolved > by moving the EOF check after reading the size and type, ensuring the > EOF flag is set when necessary. >=20 > Signed-off-by: Kacper Michaj=C5=82ow <kasper93@gmail.com> > --- > libavformat/mov.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB z(9) =3D an object that transcends all computable functions describable in finite terms. - ChatGPT in 2024 --JY+SC33kxmVlLmw2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ6UjTgAKCRBhHseHBAsP q2Q8AJ9edCfaaO24dA+uGoW4pjMxcrF2kwCeJWoADCneKz5QM0u11q6t97nNrj0= =OUrt -----END PGP SIGNATURE----- --JY+SC33kxmVlLmw2-- --===============9116207279606530559== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============9116207279606530559==--