[FFmpeg-devel] [PATCH] avformat/mxfdec: Check edit unit for overflow in mxf_set_current_edit_unit()

[FFmpeg-devel] [PATCH] avformat/mxfdec: Check edit unit for overflow in mxf_set_current_edit_unit()

[Michael Niedermayer]

Fixes: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long'
Fixes: 392672068/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-6232335892152320

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavformat/mxfdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
index 6bc8980d9c1..3b87063c3f2 100644
--- a/libavformat/mxfdec.c
+++ b/libavformat/mxfdec.c
@@ -3956,7 +3956,7 @@ static int64_t mxf_set_current_edit_unit(MXFContext *mxf, AVStream *st, int64_t
     int64_t new_edit_unit;
     MXFIndexTable *t = mxf_find_index_table(mxf, track->index_sid);
 
-    if (!t || track->wrapping == UnknownWrapped)
+    if (!t || track->wrapping == UnknownWrapped || edit_unit > INT64_MAX - track->edit_units_per_packet)
         return -1;
 
     if (mxf_edit_unit_absolute_offset(mxf, t, edit_unit + track->edit_units_per_packet, track->edit_rate, NULL, &next_ofs, NULL, 0) < 0 &&
-- 
2.48.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check edit unit for overflow in mxf_set_current_edit_unit()

[Tomas Härdin]

ons 2025-02-05 klockan 12:56 +0100 skrev Michael Niedermayer:
> Fixes: signed integer overflow: 9223372036854775807 + 1 cannot be
> represented in type 'long'
> Fixes: 392672068/clusterfuzz-testcase-minimized-
> ffmpeg_dem_MXF_fuzzer-6232335892152320
> 
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavformat/mxfdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index 6bc8980d9c1..3b87063c3f2 100644
> --- a/libavformat/mxfdec.c
> +++ b/libavformat/mxfdec.c
> @@ -3956,7 +3956,7 @@ static int64_t
> mxf_set_current_edit_unit(MXFContext *mxf, AVStream *st, int64_t
>      int64_t new_edit_unit;
>      MXFIndexTable *t = mxf_find_index_table(mxf, track->index_sid);
>  
> -    if (!t || track->wrapping == UnknownWrapped)
> +    if (!t || track->wrapping == UnknownWrapped || edit_unit >
> INT64_MAX - track->edit_units_per_packet)

Looks OK

/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check edit unit for overflow in mxf_set_current_edit_unit()

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1500 bytes --]

Hi

On Wed, Feb 05, 2025 at 03:53:23PM +0100, Tomas Härdin wrote:
> ons 2025-02-05 klockan 12:56 +0100 skrev Michael Niedermayer:
> > Fixes: signed integer overflow: 9223372036854775807 + 1 cannot be
> > represented in type 'long'
> > Fixes: 392672068/clusterfuzz-testcase-minimized-
> > ffmpeg_dem_MXF_fuzzer-6232335892152320
> > 
> > Found-by: continuous fuzzing process
> > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavformat/mxfdec.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> > index 6bc8980d9c1..3b87063c3f2 100644
> > --- a/libavformat/mxfdec.c
> > +++ b/libavformat/mxfdec.c
> > @@ -3956,7 +3956,7 @@ static int64_t
> > mxf_set_current_edit_unit(MXFContext *mxf, AVStream *st, int64_t
> >      int64_t new_edit_unit;
> >      MXFIndexTable *t = mxf_find_index_table(mxf, track->index_sid);
> >  
> > -    if (!t || track->wrapping == UnknownWrapped)
> > +    if (!t || track->wrapping == UnknownWrapped || edit_unit >
> > INT64_MAX - track->edit_units_per_packet)
> 
> Looks OK

will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".