From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id DB1064C39F for ; Thu, 6 Feb 2025 21:00:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 158E468B9B1; Thu, 6 Feb 2025 23:00:04 +0200 (EET) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0DF2C68B459 for ; Thu, 6 Feb 2025 22:59:56 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 22D7F44253 for ; Thu, 6 Feb 2025 20:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1738875596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3JijOEGI3GVHt/lvbrO4tR7R22xCznOcc/mqm7UiPVk=; b=arVkAiU2L3wf9L+3IHAD/ssD5vQo3IBty+zuzbAygsJAq+3bLdrG9r9JNlQfB39alx0yYr 2dsCOVB1x6+9z9/hNbzpCPz2oRH2qMEsSB7xpZiHrbKFjpjZmSKRJMo2m8U8g2JHRfuTmj 5l6hdp8wr6t31Qs4+R62PvhNl4nv0u3g5nXo9+/de9iZkdDrzONEp1UnubuDSrL+CtYwTn b7D5R+S8bX3kHdsJQwHJAjVyamyAAhKPoyyh6lrnTGGcI18zj7Ci/OcC+s+NIwlNdZWsrb fN6JQ85PGpl8H+nv3LS9DiOD4R5QX389zhf3NAjvd/Ccg250sYpQ/FrYNZxwkA== Date: Thu, 6 Feb 2025 21:59:55 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250206205955.GY4991@pb2> References: <20250205115635.2981829-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvjeegtdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtudenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepjeetfeduudefgeevjeffheeihfegudekvefgfeekgeejgfeiieetleeuieevgeeunecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check edit unit for overflow in mxf_set_current_edit_unit() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1945589760985155385==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1945589760985155385== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EF7i4nj0zxirjemP" Content-Disposition: inline --EF7i4nj0zxirjemP Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Wed, Feb 05, 2025 at 03:53:23PM +0100, Tomas H=E4rdin wrote: > ons 2025-02-05 klockan 12:56 +0100 skrev Michael Niedermayer: > > Fixes: signed integer overflow: 9223372036854775807 + 1 cannot be > > represented in type 'long' > > Fixes: 392672068/clusterfuzz-testcase-minimized- > > ffmpeg_dem_MXF_fuzzer-6232335892152320 > >=20 > > Found-by: continuous fuzzing process > > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > =A0libavformat/mxfdec.c | 2 +- > > =A01 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > > index 6bc8980d9c1..3b87063c3f2 100644 > > --- a/libavformat/mxfdec.c > > +++ b/libavformat/mxfdec.c > > @@ -3956,7 +3956,7 @@ static int64_t > > mxf_set_current_edit_unit(MXFContext *mxf, AVStream *st, int64_t > > =A0=A0=A0=A0 int64_t new_edit_unit; > > =A0=A0=A0=A0 MXFIndexTable *t =3D mxf_find_index_table(mxf, track->inde= x_sid); > > =A0 > > -=A0=A0=A0 if (!t || track->wrapping =3D=3D UnknownWrapped) > > +=A0=A0=A0 if (!t || track->wrapping =3D=3D UnknownWrapped || edit_unit= > > > INT64_MAX - track->edit_units_per_packet) >=20 > Looks OK will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Concerning the gods, I have no means of knowing whether they exist or not or of what sort they may be, because of the obscurity of the subject, and the brevity of human life -- Protagoras --EF7i4nj0zxirjemP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ6UiyAAKCRBhHseHBAsP q2HbAJ9wCTDDbjUaqRNZ7N3HZULSg7xsMACfQkJKjez/Sq/DdiF7y/WXDnAJMrE= =d05X -----END PGP SIGNATURE----- --EF7i4nj0zxirjemP-- --===============1945589760985155385== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1945589760985155385==--