From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check edit unit for overflow in mxf_set_current_edit_unit()
Date: Thu, 6 Feb 2025 21:59:55 +0100
Message-ID: <20250206205955.GY4991@pb2> (raw)
In-Reply-To: <d13238391ccd78142094d789edb5ec6d7fd5aacb.camel@haerdin.se>
[-- Attachment #1.1: Type: text/plain, Size: 1500 bytes --]
Hi
On Wed, Feb 05, 2025 at 03:53:23PM +0100, Tomas Härdin wrote:
> ons 2025-02-05 klockan 12:56 +0100 skrev Michael Niedermayer:
> > Fixes: signed integer overflow: 9223372036854775807 + 1 cannot be
> > represented in type 'long'
> > Fixes: 392672068/clusterfuzz-testcase-minimized-
> > ffmpeg_dem_MXF_fuzzer-6232335892152320
> >
> > Found-by: continuous fuzzing process
> > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> > libavformat/mxfdec.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> > index 6bc8980d9c1..3b87063c3f2 100644
> > --- a/libavformat/mxfdec.c
> > +++ b/libavformat/mxfdec.c
> > @@ -3956,7 +3956,7 @@ static int64_t
> > mxf_set_current_edit_unit(MXFContext *mxf, AVStream *st, int64_t
> > int64_t new_edit_unit;
> > MXFIndexTable *t = mxf_find_index_table(mxf, track->index_sid);
> >
> > - if (!t || track->wrapping == UnknownWrapped)
> > + if (!t || track->wrapping == UnknownWrapped || edit_unit >
> > INT64_MAX - track->edit_units_per_packet)
>
> Looks OK
will apply
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-02-06 21:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 11:56 Michael Niedermayer
2025-02-05 14:53 ` Tomas Härdin
2025-02-06 20:59 ` Michael Niedermayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206205955.GY4991@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git