Re: [FFmpeg-devel] [PATCH 1/3] avfilter/delogo: add parameter to switch on circular delogo

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1929 bytes --]

Hi Jörg

On Tue, Feb 04, 2025 at 08:53:58PM +0100, Jörg Habenicht via ffmpeg-devel wrote:
> Add a parameter (boolean) r to switch the area from
> rectangular (r=0) to circular(r=1) delogo.
> 
> Signed-off-by: Jörg Habenicht <j.habenicht@gmx.de>
> ---
>  libavfilter/vf_delogo.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/libavfilter/vf_delogo.c b/libavfilter/vf_delogo.c
> index bfbf8e6f4c..7641c3b483 100644
> --- a/libavfilter/vf_delogo.c
> +++ b/libavfilter/vf_delogo.c
> @@ -195,7 +195,7 @@ static void apply_delogo(uint8_t *dst, int dst_linesize,
> 
>  typedef struct DelogoContext {
>      const AVClass *class;
> -    int x, y, w, h, band, show;
> +    int x, y, w, h, band, show, round;
>      char *x_expr, *y_expr, *w_expr, *h_expr;
>      AVExpr *x_pexpr, *y_pexpr, *w_pexpr, *h_pexpr;
>      double var_values[VAR_VARS_NB];
> @@ -209,6 +209,7 @@ static const AVOption delogo_options[]= {
>      { "y",    "set logo y position",       OFFSET(y_expr),    AV_OPT_TYPE_STRING, { .str = "-1" }, 0, 0, FLAGS },
>      { "w",    "set logo width",            OFFSET(w_expr),    AV_OPT_TYPE_STRING, { .str = "-1" }, 0, 0, FLAGS },
>      { "h",    "set logo height",           OFFSET(h_expr),    AV_OPT_TYPE_STRING, { .str = "-1" }, 0, 0, FLAGS },
> +    { "r",    "logo is round/ellipse",     OFFSET(round),     AV_OPT_TYPE_BOOL,   { .i64 =  0 },   0, 1, FLAGS },

maybe a superellipse would be interresting
https://en.wikipedia.org/wiki/Superellipse

This would allow intermediates between a rectangle, elipse and rhombus
I imagine this could cover more cases of logos

either way teh 3 patches should be merged

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The smallest minority on earth is the individual. Those who deny 
individual rights cannot claim to be defenders of minorities. - Ayn Rand

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".