Re: [FFmpeg-devel] [PATCH] fix pad artifacting

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 2080 bytes --]

Hi Ben

On Mon, Feb 03, 2025 at 04:02:15PM +0000, Ben Lu via ffmpeg-devel wrote:
> Sure, looks like gmail is complying with a plaintext email RFC. Let me try
> attaching to eml with:
> `git format-patch -s -o "outputfolder" --add-header "X-Unsent: 1" --suffix
> .eml --to ffmpeg-devel@ffmpeg.org -1 0f497eb391b`
> 
> On Mon, Feb 3, 2025 at 3:22 PM James Almer <jamrial@gmail.com> wrote:
> 
> > On 2/3/2025 10:58 AM, Ben Lu via ffmpeg-devel wrote:
> > > Sorry about that, it looks correct in gmail and sending to myself also
> > > looks fine, not sure where the line width corruption is happening. Our
> > org
> > > doesn't allow programmatic email.
> >
> > Looks like lines with a single blank space are being replaced by empty
> > lines.
> >
> > >
> > > Is it possible to use this gist?
> >
> > Try to attach the output of git format-patch to an email instead. That
> > gist is only a diff of changes and missing all the git commit info.
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> >

> Date: Fri, 31 Jan 2025 23:13:25 +0000
> From: Ben Lu <benlu@x.com>
> To: ffmpeg-devel@ffmpeg.org
> Subject: [PATCH] fix pad artifacts
> 
> Signed-off-by: Ben Lu <benlu@x.com>
> ---
>  libavfilter/vf_pad.c | 29 +++++++++++++++++++++--------
>  1 file changed, 21 insertions(+), 8 deletions(-)

A more verbose commit message would be good

Also do you have some testcase for this ?
or even better something that can be added to fate ? So that a regression
could be detected.

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If one takes all money from those who grow wealth and gives it to those who
do not grow wealth, 10 years later, almost the same people who where wealthy
will be wealthy again, the same people who where poor will be poor again.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".