From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D80F74C321 for ; Thu, 6 Feb 2025 16:16:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0B3E168BD3F; Thu, 6 Feb 2025 18:16:07 +0200 (EET) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E54E068B97D for ; Thu, 6 Feb 2025 18:16:00 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 547E3431FE for ; Thu, 6 Feb 2025 16:15:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1738858560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0hI8JfReoMaJ4eYizHp48hEJgY2Ub02mPS6pD9p1WAk=; b=P9pASTmHmyuspYNDQMFrnwMIL8e1F29vReHaVHaK1I5yiCQSSDDfj7X1O2C5WNuK+VOMaN UoyibTG77mR4gqaY2zVeRNScklWOaS2IvFL+K4OFHgRQTTPsmPkcLIs0rjj4CwwuKiN++O wTBhtFnoic79ZWBoSRSZjyT1562MZqZ1ENar51/sTMS5OYLYdd/XEhfab8oaTm1VtIaelw ekz6kHrQZe92lrM7bBgkcM9taUWzp1A6+FAkt4HPn/zniUYwyBY+zO8BRSUcts4OoxkfwZ QoQBKvU3XVzmmyvj40Jgv7yFJytg2B+m9ntgprjJu3STbef8JLCTNV5W7Um8oA== Date: Thu, 6 Feb 2025 17:15:59 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250206161559.GV4991@pb2> References: <20250202214642.5316-1-jamrial@gmail.com> MIME-Version: 1.0 In-Reply-To: <20250202214642.5316-1-jamrial@gmail.com> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvieekgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieegkedtjeduffejhfetgeejtdegteetgfegtdfhjefgvefhteegkeejtddvhfevnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/2] swresample/rematrix: split filling the matrix array into its own function X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4806643814291696016==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4806643814291696016== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4MTlccsK2mRhhXwp" Content-Disposition: inline --4MTlccsK2mRhhXwp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 02, 2025 at 06:46:41PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libswresample/rematrix.c | 202 ++++++++++++++++++++------------------- > 1 file changed, 106 insertions(+), 96 deletions(-) >=20 > diff --git a/libswresample/rematrix.c b/libswresample/rematrix.c > index b9bf4dcac0..8b6e8ae1c5 100644 > --- a/libswresample/rematrix.c > +++ b/libswresample/rematrix.c > @@ -124,85 +124,28 @@ static int sane_layout(AVChannelLayout *ch_layout) { > return 1; > } > =20 > -av_cold int swr_build_matrix2(const AVChannelLayout *in_layout, const AV= ChannelLayout *out_layout, > - double center_mix_level, double surround_m= ix_level, > - double lfe_mix_level, double maxval, > - double rematrix_volume, double *matrix_par= am, > - ptrdiff_t stride, enum AVMatrixEncoding ma= trix_encoding, void *log_context) > +static void build_matrix(const AVChannelLayout *in_ch_layout, const AVCh= annelLayout *out_ch_layout, > + double center_mix_level, double surround_mix_le= vel, > + double lfe_mix_level, double maxval, double rem= atrix_volume, double *matrix_param, > + ptrdiff_t stride, enum AVMatrixEncoding matrix_= encoding) Please document new functions, even if its just refering to swr_build_matrix2() docs thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope --4MTlccsK2mRhhXwp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ6TgPwAKCRBhHseHBAsP qyQIAJ9TpSpUFBg0S4/+QeDbs5i47Y5j1ACeODz5ZfrcR3mi1cMM6ofVQLsWydA= =T2U3 -----END PGP SIGNATURE----- --4MTlccsK2mRhhXwp-- --===============4806643814291696016== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4806643814291696016==--