Re: [FFmpeg-devel] [PATCH 1/2] swresample/rematrix: split filling the matrix array into its own function

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] swresample/rematrix: split filling the matrix array into its own function
Date: Thu, 6 Feb 2025 17:15:59 +0100
Message-ID: <20250206161559.GV4991@pb2> (raw)
In-Reply-To: <20250202214642.5316-1-jamrial@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1628 bytes --]

On Sun, Feb 02, 2025 at 06:46:41PM -0300, James Almer wrote:
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libswresample/rematrix.c | 202 ++++++++++++++++++++-------------------
>  1 file changed, 106 insertions(+), 96 deletions(-)
> 
> diff --git a/libswresample/rematrix.c b/libswresample/rematrix.c
> index b9bf4dcac0..8b6e8ae1c5 100644
> --- a/libswresample/rematrix.c
> +++ b/libswresample/rematrix.c
> @@ -124,85 +124,28 @@ static int sane_layout(AVChannelLayout *ch_layout) {
>      return 1;
>  }
>  
> -av_cold int swr_build_matrix2(const AVChannelLayout *in_layout, const AVChannelLayout *out_layout,
> -                              double center_mix_level, double surround_mix_level,
> -                              double lfe_mix_level, double maxval,
> -                              double rematrix_volume, double *matrix_param,
> -                              ptrdiff_t stride, enum AVMatrixEncoding matrix_encoding, void *log_context)
> +static void build_matrix(const AVChannelLayout *in_ch_layout, const AVChannelLayout *out_ch_layout,
> +                         double center_mix_level, double surround_mix_level,
> +                         double lfe_mix_level, double maxval, double rematrix_volume, double *matrix_param,
> +                         ptrdiff_t stride, enum AVMatrixEncoding matrix_encoding)

Please document new functions, even if its just refering
to swr_build_matrix2() docs

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".