From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id C6F544C2D6 for ; Thu, 6 Feb 2025 14:58:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C51C968BC83; Thu, 6 Feb 2025 16:58:25 +0200 (EET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 01EF368AFF3 for ; Thu, 6 Feb 2025 16:58:18 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 56B5C44285 for ; Thu, 6 Feb 2025 14:58:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1738853898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IoHdqVKC2Q3A9M0GTj/3e+449LdC5oDlOvXdOl2wWH0=; b=Bi9gc70X/23zFRROM51u2+9Cw7SGwflIiO4S4VLCBiLW1pbRMLNPaq+s8AqymV2Ti75QPd TnBJQ0cr91nioHu+i7G1gikxPLYxZ5F4OZsDGnZF/BLrZe4/iqmw55fRTx/fo73k2wDfgx G25eOsPw54P6oCbw9sLaANjfyuNbxJEqYYAcpHWs6STpniBo1nTI98S01FYYegq2t7xd4T wyVta9s4/oBe6IvZWNlATG4Y+NZd1t9ISL1UlWOHuNotgqM7cBeXoEurzRLoMT9EdTW21J sAimr3sTSzc2iGa9jptWpDvO8k19OLBLnhXAha7OZX4a/cX1lF9vxMr9rSOvDA== Date: Thu, 6 Feb 2025 15:58:17 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250206145817.GN4991@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvieeilecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtudenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepudetvdfhudeuudegudefgfehhfevvdfggfffkefhvdfgvdetffdtjeekheetfeehnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 8/8] Make mime-type award a bonus probe score X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6431987812877546160==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6431987812877546160== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8VGVzuMzAyOtMsk7" Content-Disposition: inline --8VGVzuMzAyOtMsk7 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Tomas On Wed, Feb 05, 2025 at 03:24:24PM +0100, Tomas H=E4rdin wrote: > Seems reasonable to me and passes FATE >=20 > /Tomas > avformat.h | 2 +- > format.c | 8 ++++---- > libopenmpt.c | 2 +- > 3 files changed, 6 insertions(+), 6 deletions(-) > 01f04f79202640330d6be91b0215f92f14d1845a 0008-Make-mime-type-award-a-bon= us-probe-score.patch > From ecc3459990f2871fd907f96fe66362b8fea41bd8 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Peter=3D20Zeb=3DC3=3DBChr?=3D > Date: Tue, 21 Nov 2023 14:16:49 +0100 > Subject: [PATCH 8/8] Make mime-type award a bonus probe score >=20 > This changes the default behaviour of ffmpeg where content-type headers > on an input gives an absolut probe score (of 75) to instead give a bonus > score (of 30). This gives the probe a better chance to arrive at the > correct format by (hopefully) giving a large enough bonus to push edge > cases in the right direction (MPEG-PS vs MP3, I am looking at you) while > also not adversly punishing clearer cases (raw ADTS marked as > "audio/mpeg" for example). >=20 > This patch was regression tested against 20 million recent podcast > submissions (after content-type propagation was added to > original-storage), and 50k Juno vodcasts submissions (dito). No adverse > effects observed (but the bonus may still need tweaking if other edge > cases are detected in production). > --- > libavformat/avformat.h | 2 +- > libavformat/format.c | 8 ++++---- > libavformat/libopenmpt.c | 2 +- > 3 files changed, 6 insertions(+), 6 deletions(-) what is the score ? a higher score means more likely but how much more ? maybe we should come up with a more formal definition like that score is the number of bits of entropy that where checked or something like that. in such a framework, adding 30 for a mime type match would probably make sense without such a framework, adding 30 to a abstract score is hard to review beyond that, i dont see anything breaking from this but then i dont think we have real tests for mime types thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Freedom in capitalist society always remains about the same as it was in ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin --8VGVzuMzAyOtMsk7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ6TN/wAKCRBhHseHBAsP q/pcAJ4gkHFRtvHPYiKeU+1yp9wbUiC+7ACfcYkc6y0knRbIJS00cWoAjbGBmTo= =XLmH -----END PGP SIGNATURE----- --8VGVzuMzAyOtMsk7-- --===============6431987812877546160== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6431987812877546160==--