Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3 2/2] Add stream dump test with test for ogg/flac.
Date: Thu, 6 Feb 2025 04:03:32 +0100
Message-ID: <20250206030332.GL4991@pb2> (raw)
In-Reply-To: <20250204123145.53059-3-romain.beauxis@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 2616 bytes --]

On Tue, Feb 04, 2025 at 07:31:45AM -0500, Romain Beauxis wrote:
> This is the new FATE test.
> 
> Test samples are available here: https://www.dropbox.com/scl/fo/fxt2edwkyj2mjc9qubku5/AICHxJyxMMAK8MIJqWLcvk4?rlkey=mlt12lsu741ejukz0p5qtn9rq&dl=0
> 
> Output prior to the changes is:
> Stream ID: 0, codec name: flac, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> Stream ID: 0, packet PTS: 0, packet DTS: 0
> Stream ID: 0, frame PTS: 0, metadata:
> Stream ID: 0, packet PTS: 4608, packet DTS: 4608
> Stream ID: 0, frame PTS: 4608, metadata:
> Stream ID: 0, packet PTS: 0, packet DTS: 0
> Stream ID: 0, packet PTS: 0, packet DTS: 0
> Stream ID: 0, packet PTS: 0, packet DTS: 0
> Stream ID: 0, frame PTS: 0, metadata:
> Stream ID: 0, packet PTS: 4608, packet DTS: 4608
> Stream ID: 0, frame PTS: 4608, metadata:
> 
> Output after the changes:
> Stream ID: 0, codec name: flac, metadata: encoder=Lavc61.19.100 flac:title=First Stream
> Stream ID: 0, packet PTS: 0, packet DTS: 0
> Stream ID: 0, frame PTS: 0, metadata:
> Stream ID: 0, packet PTS: 4608, packet DTS: 4608
> Stream ID: 0, frame PTS: 4608, metadata:
> Stream ID: 0, packet PTS: 0, packet DTS: 0
> Stream ID: 0, packet PTS: 0, packet DTS: 0
> Stream ID: 0, packet PTS: 0, packet DTS: 0
> Stream ID: 0, frame PTS: 0, metadata: encoder=Lavc61.19.100 flac:title=Second Stream
> Stream ID: 0, packet PTS: 4608, packet DTS: 4608
> Stream ID: 0, frame PTS: 4608, metadata:
> 
> ---
>  tests/Makefile                        |   2 +
>  tests/api/Makefile                    |   2 +-
>  tests/api/api-dump-stream-meta-test.c | 169 ++++++++++++++++++++++++++
>  tests/fate/api.mak                    |   5 +
>  tests/fate/ogg-flac.mak               |  11 ++

This is missing:
./tests/ref/fate/api-dump-stream-meta

also make fate fails like this:
TEST    api-dump-stream-meta
reference file './tests/ref/fate/api-dump-stream-meta' not found
./tests/fate-run.sh: 705: cannot open tests/data/fate/api-dump-stream-meta.diff: No such file
Test api-dump-stream-meta failed. Look at tests/data/fate/api-dump-stream-meta.err for details.
make: *** [tests/Makefile:313: api-dump-stream-meta] Error 1

but the failed part cant be run

make api-dump-stream-meta
make: *** No rule to make target 'api-dump-stream-meta'.  Stop.

also if i add a empty reference file
make fate passes

so it seems there is some bug in this

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2025-02-06  3:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-04 12:31 [FFmpeg-devel] [PATCH v3 0/2] Properly decode ogg metadata in ogg/flac chained bitstreams Romain Beauxis
2025-02-04 12:31 ` [FFmpeg-devel] [PATCH v3 1/2] Parse and process ogg/flac comments in " Romain Beauxis
2025-02-04 12:31 ` [FFmpeg-devel] [PATCH v3 2/2] Add stream dump test with test for ogg/flac Romain Beauxis
2025-02-06  3:03   ` Michael Niedermayer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250206030332.GL4991@pb2 \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git