Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 5/6] avcodec/hevc/sei: dynamically allocate 3D Reference Displays Information SEI messages
Date: Thu, 6 Feb 2025 02:56:14 +0100
Message-ID: <20250206015614.GJ4991@pb2> (raw)
In-Reply-To: <20250203223546.12224-5-jamrial@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1861 bytes --]

On Mon, Feb 03, 2025 at 07:35:45PM -0300, James Almer wrote:
> Considerably reduces the size of HEVCSEI and eliminates data copy between threads.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavcodec/hevc/hevcdec.c | 4 ++--
>  libavcodec/hevc/refs.c    | 4 ++--
>  libavcodec/hevc/sei.c     | 6 +++++-
>  libavcodec/hevc/sei.h     | 6 +++++-
>  4 files changed, 14 insertions(+), 6 deletions(-)

this segfaults here, will probably retest tomorrow without other patches
but i removed the ones you pointed to

[vist#0:0/hevc @ 0x12015580] [dec:hevc @ 0x1201b240] View with index 1 requested, but only 1 views available in current video sequence (more views may or may not be available in later sequences).
==307141== Thread 6 dec0:0:hevc:
==307141== Invalid read of size 1
==307141==    at 0x93F313: export_multilayer (in ffmpeg/ffmpeg_g)
==307141==    by 0x94B51F: hevc_receive_frame (in ffmpeg/ffmpeg_g)
==307141==    by 0x8798AA: ff_decode_receive_frame_internal (in ffmpeg/ffmpeg_g)
==307141==    by 0x879F54: decode_receive_frame_internal (in ffmpeg/ffmpeg_g)
==307141==    by 0x87A229: avcodec_send_packet (in ffmpeg/ffmpeg_g)
==307141==    by 0x2FBE13: decoder_thread (in ffmpeg/ffmpeg_g)
==307141==    by 0x31D6AE: task_wrapper (in ffmpeg/ffmpeg_g)
==307141==    by 0x4A06608: start_thread (pthread_create.c:477)
==307141==    by 0x772A352: clone (clone.S:95)
==307141==  Address 0x3 is not stack'd, malloc'd or (recently) free'd



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Any man who breaks a law that conscience tells him is unjust and willingly 
accepts the penalty by staying in jail in order to arouse the conscience of 
the community on the injustice of the law is at that moment expressing the 
very highest respect for law. - Martin Luther King Jr

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-02-06  1:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-03 22:35 [FFmpeg-devel] [PATCH v2 1/6] avutil: add an API to handle Three Dimensional Reference Displays Information James Almer
2025-02-03 22:35 ` [FFmpeg-devel] [PATCH v2 2/6] avutil/frame: add a 3D Reference Displays Information side data type James Almer
2025-02-03 22:35 ` [FFmpeg-devel] [PATCH v2 3/6] avfilter/vf_showinfo: add support for 3D Reference Displays Information side data James Almer
2025-02-03 22:35 ` [FFmpeg-devel] [PATCH 4/6] avcodec/hevc/sei: ensure num_ref_displays is not set unless the SEI message is valid James Almer
2025-02-03 22:35 ` [FFmpeg-devel] [PATCH 5/6] avcodec/hevc/sei: dynamically allocate 3D Reference Displays Information SEI messages James Almer
2025-02-06  1:56   ` Michael Niedermayer [this message]
2025-02-06  2:50     ` [FFmpeg-devel] [PATCH v2 " James Almer
2025-02-03 22:35 ` [FFmpeg-devel] [PATCH v2 6/6] avcodec/hevc/hevcdec: export 3D Reference Displays side data James Almer
2025-02-05 21:07   ` Michael Niedermayer
2025-02-05 21:16     ` James Almer
2025-02-05 21:36       ` Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250206015614.GJ4991@pb2 \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git