From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 49EDD4BB22 for ; Sat, 1 Feb 2025 02:13:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F293668C233; Sat, 1 Feb 2025 04:13:09 +0200 (EET) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 71C5B68C178 for ; Sat, 1 Feb 2025 04:13:03 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id C872444197 for ; Sat, 1 Feb 2025 02:13:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1738375983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zlECPmzM0ReGAkTdG0tW0IDs38OG8c2QxTs4R0fCauI=; b=fTN6E3qr5Fxd9HP3WCShG8yQ5fFaCa/gbzafrtOvTYVoHvCD1IWUveX2jBTjECKdfAwNbp 5DTiaw/NVG6dBT6Sa9iuBZlXUivJIEDnYkTytqMspvHej6fZRdGvLuMpbxqqdQSWxV6NhC 6LfEc+lnxKsKT+SNHljUgW/c7p6rLj2y8XG6nxIpN4b8DJlqTL9ntAcoerESj5EMrXW2PG hSOysYaqim49ei5ukbyGDFpWZ8RPZoTY4FWAcnuZ/gsRgaA58abwJvoKjDRRLcaiBH9MGN fhoOIzkERFXFGvJTyGi/IgYOP8mrDLTAM1/1R0Hdn352a6qJR2xx+xhChkpZYA== Date: Sat, 1 Feb 2025 03:13:01 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250201021301.GL4991@pb2> References: <20250117204315.GO4991@pb2> <20250125004645.GF4991@pb2> <90daf990-cdc3-4cf5-94af-f1eec9a093c1@mediaarea.net> MIME-Version: 1.0 In-Reply-To: <90daf990-cdc3-4cf5-94af-f1eec9a093c1@mediaarea.net> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddutdeghecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtudenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepudetvdfhudeuudegudefgfehhfevvdfggfffkefhvdfgvdetffdtjeekheetfeehnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat: add DAT (Digital Audio Tape) demuxer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2698132847981469571==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2698132847981469571== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5n1n8ue5Z/WAAlRJ" Content-Disposition: inline --5n1n8ue5Z/WAAlRJ Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Jerome On Wed, Jan 29, 2025 at 06:02:57PM +0100, Jerome Martinez wrote: > Le 25/01/2025 =E0 01:46, Michael Niedermayer a =E9crit=A0: > > [...] > > this passes tests. > >=20 > > but if you want, you could instead of testing "extra metadata (not need= ed for decoding)" > > test more than 1 packet > >=20 > > having a best case score of 1 seems to be something that will > > likely fail sooner or later by not detecting a dat file >=20 > Maybe misunderstanding, the cdxl parser provides score of 1, the DAT patc= hes > provide a score of the count of detected frames so better. yes, this is the 2nd such dumb mistake i make in the last few days the whole (still ongoing) "mobbing" compaign against me seems to affect the quality of my reviews and work > But attached is a v2 of the 2nd patch, less compilation warnings, using l= ess > metadata not impacting the decoding and handling corner cases like bad > metadata e.g. 16-bit 4-ch (impossible) and 32 kHz 12-bit 4-ch. > 12-bit is not yet handled but the patch provides the detection of such fi= le > and a smooth rejection of the file. >=20 > J=E9r=F4me > dat.c | 49 ++++++++++++++++++++++++++++++++++++------------- > 1 file changed, 36 insertions(+), 13 deletions(-) > cf8d17c26eddaa608bcaa8551c263e6efb077f3d 0002-avformat-dat-improve-DAT-d= emuxer.patch > From 90211198a936ca7087dbf04e5d636fd9992a8332 Mon Sep 17 00:00:00 2001 > From: Jerome Martinez > Date: Wed, 22 Jan 2025 16:08:18 +0100 > Subject: [PATCH 2/4] avformat/dat: improve DAT demuxer >=20 > Less false positive detection > Better computation of data size with 12-bit [...] > @@ -82,21 +97,29 @@ static int parse_frame(uint8_t *frame, AVCodecParamet= ers *par) > uint8_t *mainid =3D subid+4; > int chan_index =3D (mainid[0] >> 0) & 0x3; > int rate_index =3D (mainid[0] >> 2) & 0x3; > + int fmtid =3D (mainid[0] >> 6) & 0x3; > + int trackpitch =3D (mainid[1] >> 2) & 0x3; > int enc_index =3D (mainid[1] >> 6) & 0x3; > int dataid =3D (subid[0] >> 0) & 0xf; > + int encoded_size =3D 0; > + int encoded_size =3D encoded_samples[rate_index] * encoded_samples_m= ul[trackpitch] * encoded_chans[chan_index] * encoded_quantization[enc_index= ] / 8; duplicate variable thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualities wherein our enemies excel us and endeavor to excel them, by avoiding what is faulty, and imitating what is excellent in them. -- Plutarch --5n1n8ue5Z/WAAlRJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ52DKgAKCRBhHseHBAsP q/tIAJ9s+YSYK6xTdIuEvv1nsbq76XXJ5QCgho20hkXkGVoSU66Bx8BSiQC/mkU= =iWa3 -----END PGP SIGNATURE----- --5n1n8ue5Z/WAAlRJ-- --===============2698132847981469571== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2698132847981469571==--