From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 194E64BB1C for ; Sat, 1 Feb 2025 02:01:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D264768C20D; Sat, 1 Feb 2025 04:01:30 +0200 (EET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1A1B668B2B1 for ; Sat, 1 Feb 2025 04:01:24 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 31DF1204A5 for ; Sat, 1 Feb 2025 02:01:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1738375283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bd/bCJ0kmDJs00y/ZIfi2+7y6/k0EOQbllZjpa8h3RQ=; b=cgZNefDm5A45rvXZRTi46A0hPZ5juXXCtbBwcIjzpSWBb5hFPy4Yw6e38KsJgWpPRe1lK0 lVWuMOYDjkAMqUaonSZSftDaSGnb+Uf+FNtyOw4ijNMNM6RTFMk9kM7VU1duyhzevcAFZO z4H0za8bXiJIXPaja0nP+otQ6bFpy94Mdoold08vH1I3c7IQAknxLAFrmaTXvMeLiZjKhR hqGxDGRi2S+7/1+WsSE1jYaAg4rgYsPrTW6ZM3ZxZIQ2WuBBy5CWgE70ZA7OKk4WgsCnul pWKu1hv/aNZlbsUMQORrf3TyPxV+1a5AR/efEVEzJdtcKPu267g6Knh1uMgmiw== Date: Sat, 1 Feb 2025 03:01:21 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250201020121.GK4991@pb2> References: <20250128125757.742-1-jamrial@gmail.com> <20250201014355.GJ4991@pb2> <84e46052-e337-41a0-b940-3391ec3fff0d@gmail.com> MIME-Version: 1.0 In-Reply-To: <84e46052-e337-41a0-b940-3391ec3fff0d@gmail.com> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddutdegfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepleekgefgffeiudefjeeuffejudehtddtudeltdehveevvedtieeulefhtdeutdeknecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avdevice/alsa_dec: add a ch_layout option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6487096615722846908==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6487096615722846908== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="B6iOIar8KqGmxy6/" Content-Disposition: inline --B6iOIar8KqGmxy6/ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 31, 2025 at 10:45:13PM -0300, James Almer wrote: > On 1/31/2025 10:43 PM, Michael Niedermayer wrote: > > On Tue, Jan 28, 2025 at 09:57:57AM -0300, James Almer wrote: > > > Missed in ffc4fd3cc2ccb2cadb71f19849842b18ca1281c6, which after > > > e78173557da898f18a78241cc3525b76694164b5 broke setting channel count. > > >=20 > > > Should fix ticket #11434. > > >=20 > > > Signed-off-by: James Almer > > > --- > > > libavdevice/alsa.h | 4 ++++ > > > libavdevice/alsa_dec.c | 24 +++++++++++++++++++----- > > > libavdevice/version_major.h | 1 + > > > 3 files changed, 24 insertions(+), 5 deletions(-) > >=20 > > seems not to build on its own (if its intended to) >=20 > I can't test, so i wrote it blindly. >=20 > >=20 > > libavdevice/alsa_dec.c:163:59: error: =E2=80=98AV_OPT_TYPE_CH_LAYOUT=E2= =80=99 undeclared here (not in a function); did you mean =E2=80=98AV_OPT_TY= PE_CHLAYOUT=E2=80=99? > > 163 | { "ch_layout", "", offsetof(AlsaData, ch_layout), AV_O= PT_TYPE_CH_LAYOUT, {.str =3D "2C"}, INT_MIN, INT_MAX, AV_OPT_FLAG_DECODING_= PARAM }, > > | ^~~~= ~~~~~~~~~~~~~~~~~ > > | AV_O= PT_TYPE_CHLAYOUT >=20 > Is that the only error? Can you check if it compiles if you fix that typo? builds and passes fate happy to be able to help thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have often repented speaking, but never of holding my tongue. -- Xenocrates --B6iOIar8KqGmxy6/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ52AZwAKCRBhHseHBAsP qwBWAJ9BlD2xVZ1ZYLk3RCabOWRw5utjUQCdHHKb1nU6uN6dYc0hievoPPiusCc= =FcIS -----END PGP SIGNATURE----- --B6iOIar8KqGmxy6/-- --===============6487096615722846908== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6487096615722846908==--