Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] avformat/mov: fix parsing lhvc boxes with no NALU arrays
@ 2025-02-01  1:33 James Almer
  0 siblings, 0 replies; only message in thread
From: James Almer @ 2025-02-01  1:33 UTC (permalink / raw)
  To: ffmpeg-devel

Return if the box is empty at the point the arrays should start.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavformat/mov.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/libavformat/mov.c b/libavformat/mov.c
index 2c8be51063..05afda4169 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -8435,9 +8435,15 @@ static int mov_read_lhvc(MOVContext *c, AVIOContext *pb, MOVAtom atom)
 
     num_arrays = buf[5];
     old_size = st->codecpar->extradata_size;
-    atom.size -= 8 /* account for mov_realloc_extradata offseting */
-               + 6 /* lhvC bytes before the arrays*/;
+    atom.size -= 6; /* lhvC bytes before the arrays*/
 
+    if (!atom.size) {
+        av_free(buf);
+        av_log(c->fc, AV_LOG_WARNING, "empty lhvC atom\n");
+        return 0;
+    }
+
+    st->codecpar->extradata_size -= 8; /* account for mov_realloc_extradata offseting */
     ret = mov_realloc_extradata(st->codecpar, atom);
     if (ret < 0) {
         av_free(buf);
-- 
2.48.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-02-01  1:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-01  1:33 [FFmpeg-devel] [PATCH] avformat/mov: fix parsing lhvc boxes with no NALU arrays James Almer

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git