Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] fix pad artifacting
Date: Sat, 1 Feb 2025 01:52:21 +0100
Message-ID: <20250201005221.GI4991@pb2> (raw)
In-Reply-To: <CAKqKKhu+3Pabgt-F1gJK6ZXmQ=YQbsjqG7aDdUtReqbFrVgerQ@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1166 bytes --]

Hi

On Sat, Feb 01, 2025 at 12:18:08AM +0000, Ben Lu via ffmpeg-devel wrote:
> When using pad with eval=frame with variable frame sizes, we get
> significant artifacting. This is due to incorrect frame sizes, resulting in
> invalid frames. Made changes to use the output width and height for frame
> sizes when using eval=frame, with if statement guards to make sure the
> normal usage is unaffected
> 
> Signed-off-by: Ben Lu <benlu@x.com>
> ---
>  libavfilter/vf_pad.c | 29 +++++++++++++++++++++--------
>  1 file changed, 21 insertions(+), 8 deletions(-)
> 
> diff --git a/libavfilter/vf_pad.c b/libavfilter/vf_pad.c
> index 49fb272b24..846dd0a9f4 100644
> --- a/libavfilter/vf_pad.c
> +++ b/libavfilter/vf_pad.c
> @@ -237,15 +237,24 @@ static AVFrame *get_video_buffer(AVFilterLink
> *inlink, int w, int h)

error: corrupt patch at line 10

check your editor line/word wrap break settings or attach the patch or use git send-email

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

"I am not trying to be anyone's saviour, I'm trying to think about the
 future and not be sad" - Elon Musk


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-02-01  0:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-01  0:18 Ben Lu via ffmpeg-devel
2025-02-01  0:52 ` Michael Niedermayer [this message]
2025-02-03 13:58   ` Ben Lu via ffmpeg-devel
2025-02-03 15:22     ` James Almer
2025-02-03 16:02       ` Ben Lu via ffmpeg-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250201005221.GI4991@pb2 \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git