From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH v2 6/6] avcodec/hevc/hevcdec: export 3D Reference Displays side data
Date: Fri, 31 Jan 2025 17:58:55 -0300
Message-ID: <20250131205855.23609-1-jamrial@gmail.com> (raw)
In-Reply-To: <20250131140020.10887-6-jamrial@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>
---
libavcodec/hevc/hevcdec.c | 57 ++++++++++++++++++++++++++++++++++++++-
1 file changed, 56 insertions(+), 1 deletion(-)
Now actually filling the correct side data array.
diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec/hevc/hevcdec.c
index 7d3e844945..db97d9b0a2 100644
--- a/libavcodec/hevc/hevcdec.c
+++ b/libavcodec/hevc/hevcdec.c
@@ -36,6 +36,7 @@
#include "libavutil/opt.h"
#include "libavutil/pixdesc.h"
#include "libavutil/stereo3d.h"
+#include "libavutil/tdrdi.h"
#include "libavutil/timecode.h"
#include "aom_film_grain.h"
@@ -4015,6 +4016,60 @@ static int hevc_update_thread_context(AVCodecContext *dst,
}
#endif
+static int hevc_sei_to_context(AVCodecContext *avctx, HEVCSEI *sei)
+{
+ int ret;
+
+ if (sei->tdrdi.num_ref_displays) {
+ AVBufferRef *buf;
+ size_t size;
+ AV3DReferenceDisplaysInfo *tdrdi = av_tdrdi_alloc(&size);
+
+ if (!tdrdi)
+ return AVERROR(ENOMEM);
+
+ buf = av_buffer_create((uint8_t *)tdrdi, size, NULL, NULL, 0);
+ if (!buf) {
+ av_free(tdrdi);
+ return AVERROR(ENOMEM);
+ }
+
+ tdrdi->prec_ref_display_width = sei->tdrdi.prec_ref_display_width;
+ tdrdi->ref_viewing_distance_flag = sei->tdrdi.ref_viewing_distance_flag;
+ tdrdi->prec_ref_viewing_dist = sei->tdrdi.prec_ref_viewing_dist;
+ tdrdi->num_ref_displays = sei->tdrdi.num_ref_displays;
+ memcpy(tdrdi->left_view_id,
+ sei->tdrdi.left_view_id, sizeof(tdrdi->left_view_id));
+ memcpy(tdrdi->right_view_id,
+ sei->tdrdi.right_view_id, sizeof(tdrdi->right_view_id));
+ memcpy(tdrdi->exponent_ref_display_width,
+ sei->tdrdi.exponent_ref_display_width, sizeof(tdrdi->exponent_ref_display_width));
+ memcpy(tdrdi->mantissa_ref_display_width,
+ sei->tdrdi.mantissa_ref_display_width, sizeof(tdrdi->mantissa_ref_display_width));
+ memcpy(tdrdi->exponent_ref_viewing_distance,
+ sei->tdrdi.exponent_ref_viewing_distance, sizeof(tdrdi->exponent_ref_viewing_distance));
+ memcpy(tdrdi->mantissa_ref_viewing_distance,
+ sei->tdrdi.mantissa_ref_viewing_distance, sizeof(tdrdi->mantissa_ref_viewing_distance));
+ memcpy(tdrdi->additional_shift_present_flag,
+ sei->tdrdi.additional_shift_present_flag, sizeof(tdrdi->additional_shift_present_flag));
+ memcpy(tdrdi->num_sample_shift,
+ sei->tdrdi.num_sample_shift, sizeof(tdrdi->num_sample_shift));
+
+ ret = ff_frame_new_side_data_from_buf_ext(avctx, &avctx->decoded_side_data, &avctx->nb_decoded_side_data,
+ AV_FRAME_DATA_3D_REFERENCE_DISPLAYS, &buf);
+ if (ret < 0) {
+ av_buffer_unref(&buf);
+ return ret;
+ }
+ }
+
+ ret = ff_h2645_sei_to_context(avctx, &sei->common);
+ if (ret < 0)
+ return ret;
+
+ return 0;
+}
+
static av_cold int hevc_decode_init(AVCodecContext *avctx)
{
HEVCContext *s = avctx->priv_data;
@@ -4038,7 +4093,7 @@ static av_cold int hevc_decode_init(AVCodecContext *avctx)
return ret;
}
- ret = ff_h2645_sei_to_context(avctx, &s->sei.common);
+ ret = hevc_sei_to_context(avctx, &s->sei);
if (ret < 0)
return ret;
}
--
2.48.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-01-31 20:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 14:00 [FFmpeg-devel] [PATCH 1/6] avutil: add an API to handle 3D Reference Displays Information James Almer
2025-01-31 14:00 ` [FFmpeg-devel] [PATCH 2/6] avutil/frame: add a 3D Reference Displays Information side data type James Almer
2025-01-31 14:00 ` [FFmpeg-devel] [PATCH 3/6] avcodec/packet: " James Almer
2025-01-31 14:00 ` [FFmpeg-devel] [PATCH 4/6] avformat/dump: add support for 3D Reference Displays Information side data James Almer
2025-01-31 14:00 ` [FFmpeg-devel] [PATCH 5/6] avfilter/vf_showinfo: " James Almer
2025-01-31 14:00 ` [FFmpeg-devel] [PATCH 6/6] avcodec/hevc/hevcdec: export 3D Reference Displays " James Almer
2025-01-31 20:58 ` James Almer [this message]
2025-02-03 22:35 [FFmpeg-devel] [PATCH v2 1/6] avutil: add an API to handle Three Dimensional Reference Displays Information James Almer
2025-02-03 22:35 ` [FFmpeg-devel] [PATCH v2 6/6] avcodec/hevc/hevcdec: export 3D Reference Displays side data James Almer
2025-02-05 21:07 ` Michael Niedermayer
2025-02-05 21:16 ` James Almer
2025-02-05 21:36 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250131205855.23609-1-jamrial@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git