Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Adam Wall <wallboy@wallboy.ca>
To: ffmpeg-devel@ffmpeg.org
Cc: Adam Wall <wallboy@wallboy.ca>
Subject: [FFmpeg-devel] [PATCH] avformat/rtmp: Increase filename size to allow for longer playpaths
Date: Thu, 30 Jan 2025 05:55:55 -0600
Message-ID: <20250130115555.4792-1-wallboy@wallboy.ca> (raw)

The current filename length for the stream name when RTMP is acting as
a server is too short. Certain services such as Amazon IVS use very
long streamkeys (close to 500 characters) when using the new enhanced
RTMP multitrack feature.

When using software such as OBS that can utilize Amazon IVS multitrack
and specifying a custom RTMP server, where that server is FFmpeg RTMP
in listen mode, then the key that gets passed over the publish
commands exceeds the current 128 length limit, resulting in a "name
too long" error.

This commit simply increases the filename size to accomodate these
longer stream names.

Signed-off-by: Adam Wall <wallboy@wallboy.ca>
---
 libavformat/rtmpproto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c
index 4095ae9421..d34678144e 100644
--- a/libavformat/rtmpproto.c
+++ b/libavformat/rtmpproto.c
@@ -1943,7 +1943,7 @@ static int send_invoke_response(URLContext *s, RTMPPacket *pkt)
 {
     RTMPContext *rt = s->priv_data;
     double seqnum;
-    char filename[128];
+    char filename[1024];
     char command[64];
     int stringlen;
     char *pchar;
-- 
2.48.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

                 reply	other threads:[~2025-01-30 11:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250130115555.4792-1-wallboy@wallboy.ca \
    --to=wallboy@wallboy.ca \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git