From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id 21E134B243
	for <ffmpegdev@gitmailbox.com>; Thu, 30 Jan 2025 00:26:33 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9462868BD9C;
	Thu, 30 Jan 2025 02:26:22 +0200 (EET)
Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com
 [209.85.128.48])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4C2C168BD5A
 for <ffmpeg-devel@ffmpeg.org>; Thu, 30 Jan 2025 02:26:16 +0200 (EET)
Received: by mail-wm1-f48.google.com with SMTP id
 5b1f17b1804b1-4361f65ca01so1838525e9.1
 for <ffmpeg-devel@ffmpeg.org>; Wed, 29 Jan 2025 16:26:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1738196775; x=1738801575; darn=ffmpeg.org;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=T7VRFyB8wTO2baFESWhCU49+Tq8DSLGMFxU0gsDIQTI=;
 b=LTuHydSrlv2QO4GBq7BZu4IPULbEpC2hH9HqKsDtuganJUGKNYhiZqpSMoPJdewZkn
 wO4B6o002znKMC+IE17KbFqqjRcuHb7ou/1H+Wr9bv5aEJ5tQwXN8nxgLou9RWaciY/Y
 Lg9Vy+fGE/+3zVIH40wwnR2erD1EwoxR97gQb/ty9Oo0vOA1ezPV6nxo1wBCnvB+2FR+
 GlS0kN7CJqS1HRj4by+dum4kr/5xbm7MwpQtodzGzipPD2E1VirFKdcMJ0ziY2FKgS++
 rL3xnrN4uz7+r6oekjImd63hqxWk+WvthZ1Wrhy/AONvJcC1mPQg9Ybj+tSw6ss8+ASQ
 xe2g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1738196775; x=1738801575;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=T7VRFyB8wTO2baFESWhCU49+Tq8DSLGMFxU0gsDIQTI=;
 b=ocWG0x4s4/DM+zri6J+jH8Gnnynyc0YbjA5ZswvhtiXKH5LebUy3lfi3FBsX9x/iKI
 OtjHnuL9wxjW1txoVCbuQwtz1PsTKJzHPvb4U/I0J1gSMhHuRhBUvg2OrE1fNbDh3mPD
 8mm+ahO1HMCFyZJaPDOrYRyI8bZMIZxGfUQzHKiXYo7FZVKUANt3wQ+BPnMfabHorYK2
 fRrich+tI49bIrrdUcup47X8BdPWHHKGQw9VgAm0eQGTFAxJbiQx1qL1wSGQdgYKxxqz
 NIzlo4Kd8JKzIx6//fIgbOFRJ+Pipnf+NWlJpoiH+ukA/oVUQ8wJAUI9SwYKko3IAEkk
 /m8g==
X-Gm-Message-State: AOJu0Yz+NnKnOP7WoZ435slX/+KGIgtfi4VIa+vyNWjf57F1uYueN1AI
 ggtMuZxgem6p0uabZ4maRPUZyxLnitR/MlEmeX028eCpQ9htZjtDqh3k3A==
X-Gm-Gg: ASbGncvIPdDYGiEjlTa3AGZL4yhn/pWAtR0W+uRiW0td2rdeSZXOAuVT0bHKUTcwR/k
 hBGaQH0gz0mBMIajVIcPyAFccInhQzAoz4Kg/a12rZeZ9pQbZD+dwY9dvyvz7UEMemqVrHbVatJ
 YJL5zQA8TgDCdFvPK5/Nq5q568BzlMKtYyJu7Lcs4kfua9AT3+D7lfkPesUDEt060o7Uw3OmOPX
 QqhUySuGq0RB9Bxpx/t2DkxaXrUeyCJWCT3O26g40QIEDAFJww3pPkrcXOXZ2fMM04vWHHpzXtK
 crwaCq5D56lXukXm4Yk2yfhCj1mopjkVCjVx11Vj0KAJ72fv9c+GtkexgY9WHrt+U0SJsK0N9pZ
 fTGuKeMSvdFB4nrDIj2g4hcTA9fMCgtX0z2qMe7PoLeled+Ij
X-Google-Smtp-Source: AGHT+IHcZ4kX5txjNOzTOMTa5PlvSEIQhqMgAheVJxKmJDZbXoaYEqCo8TGmx3bAv6nAe1qxoLyTeA==
X-Received: by 2002:a05:6000:1365:b0:38a:888c:a727 with SMTP id
 ffacd0b85a97d-38c5195dd2amr4020976f8f.25.1738196775533; 
 Wed, 29 Jan 2025 16:26:15 -0800 (PST)
Received: from MacBook-Pro-von-Marvin.fritz.box
 (p200300cccf39900035c1c9551f8739fd.dip0.t-ipconnect.de.
 [2003:cc:cf39:9000:35c1:c955:1f87:39fd])
 by smtp.gmail.com with ESMTPSA id
 ffacd0b85a97d-38c5c1017besm298181f8f.26.2025.01.29.16.26.14
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 29 Jan 2025 16:26:14 -0800 (PST)
From: Marvin Scholz <epirat07@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Date: Thu, 30 Jan 2025 01:25:52 +0100
Message-Id: <20250130002552.49220-2-epirat07@gmail.com>
X-Mailer: git-send-email 2.39.5 (Apple Git-154)
In-Reply-To: <20250130002552.49220-1-epirat07@gmail.com>
References: <20250130002552.49220-1-epirat07@gmail.com>
MIME-Version: 1.0
Subject: [FFmpeg-devel] [PATCH 2/2] lavfi/f_sendcmd: clear Command on alloc
 failure
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Marvin Scholz <epirat07@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250130002552.49220-2-epirat07@gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

If the command array failed to allocate, the current parsed
Command has to be cleared, else memory allocated for it
would be leaked.

Fix CID 1638635
---
 libavfilter/f_sendcmd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavfilter/f_sendcmd.c b/libavfilter/f_sendcmd.c
index 8a0c368108..64f284f4f1 100644
--- a/libavfilter/f_sendcmd.c
+++ b/libavfilter/f_sendcmd.c
@@ -263,6 +263,7 @@ static int parse_commands(Command **cmds, int *nb_cmds, int interval_count,
             if (!*cmds) {
                 av_log(log_ctx, AV_LOG_ERROR,
                        "Could not (re)allocate command array\n");
+                clear_command(&cmd);
                 return AVERROR(ENOMEM);
             }
         }
-- 
2.39.5 (Apple Git-154)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".