From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 102F04A369 for ; Wed, 29 Jan 2025 09:59:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6A84A68B926; Wed, 29 Jan 2025 11:59:03 +0200 (EET) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A78C668B485 for ; Wed, 29 Jan 2025 11:58:56 +0200 (EET) Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-3043e84c687so56189851fa.1 for ; Wed, 29 Jan 2025 01:58:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1738144736; x=1738749536; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=8T8bjOwoWav18UwSnN8DgNhZImzjADBEjEr2JPvC3QQ=; b=gr96GOflJZGOxnDde4MQRgJHiDnV4ZG86D68u7PHF/1mEktn0vJU5t20e+igf75snc eobxwBaAlzA1FoTG5PrwqK9pSGpw3GuDebGyOhfTwe2p/oz95kN84NrWASi6lOjB4HO3 DFhEdiE1sFiY60eDHfaZFCk4Pl7hIh5RdYTt0+I9cJV7YfPZkWy0XAnOv+dqLTn78Ikj zrcsQyiCMrVa9m4a2P9x/v4OAPT50BYiQ1hVMQQMRDw3TjyxHsbF2RaBWAQXkQv2x485 czJvo8f433/qsRdXR0pvNIW9or0ibnCfdcrt4uAK61Gn8NsoB9TPINOkZ0M1Pt3ceAu/ sv6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738144736; x=1738749536; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8T8bjOwoWav18UwSnN8DgNhZImzjADBEjEr2JPvC3QQ=; b=oAysie9OGU9AF261wCfEKs8TTLfER45j58Aj4FcIvC9W92SRwIv0+yrbwdkOtSQejH 5k7NjC4agSiR4Qrv+I8kTvXvz9C1AzTbzOyh7w80kEeFWvSrfb9xycFpTYs3X3jQsP0E 20lr1dobgffHEsr61n0z41/HNZPId3/7komkzbpLJfXwInKxUhBWgIeH50wqWbpg1ziO UYykDL1VvXhKMvCKte5aWYLv0JTi/7lL1+/T3dnm4ZkZUPHWmIQdGS6KOaJqv9oUsvXY VR7aUegzNXHnvcODzS2ScZdX3d1lL48IIOrpnV4sM37qmt9CmApeu2Uv86F7fICS2xa7 oSEQ== X-Gm-Message-State: AOJu0YyKkVq0xsFinNdRjWoUftkxctOcN/4+8CZo1K6q/KFJj6F9ibex JVB1c4TbfAzm+T2Y4kpjBix1fhci2rQ/NNR04QoTa6c5UHPHEW5iieTkLQ7Zl6LagHMyo0DzkUj rAg== X-Gm-Gg: ASbGncv1lk/67hi0D7AyWFP41QRV/hgULMj5k/7m8zcTkbIs/5wlUETnSRSd0yELYVN 15H+bLK1V5DZftkb/xCshb6TD/UnCZfQ1kqxDibKg/9aq/4LXlPUtAjLxs03ujC5JFWcW51ehpB aZj4/vygtycZ+3JjLHVO964MvI9Zoi4XqtheD6FGOeypjYM4Vjbz98y3h6qbtTypaXzlQyvzbVG wx68+Bqntf5pIX1rnaaAjD64UOqljD3YP7I5i+/cEcsr9pZ+cP/6DbgzfqrZU8LywYueq9e/skn TXJiHo5yOmnypClifxyVQj9k4Xyk3UVeTaYpphihkG8XYSLgus65Tmbh/w== X-Google-Smtp-Source: AGHT+IFDMoljc+MTh92K202Q2c9MWyfEX4LXHRDV1ZF6i+xAAdPAUGMajpXCkJZpdUBHCycymTZmsw== X-Received: by 2002:a05:651c:1608:b0:300:2d54:c2ae with SMTP id 38308e7fff4ca-307968e7b65mr12178001fa.27.1738144735577; Wed, 29 Jan 2025 01:58:55 -0800 (PST) Received: from localhost (dsl-tkubng21-50de30-198.dhcp.inet.fi. [80.222.48.198]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3076bc19561sm20652961fa.85.2025.01.29.01.58.55 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 29 Jan 2025 01:58:55 -0800 (PST) From: =?UTF-8?q?Martin=20Storsj=C3=B6?= To: ffmpeg-devel@ffmpeg.org Date: Wed, 29 Jan 2025 11:58:54 +0200 Message-Id: <20250129095854.44025-1-martin@martin.st> X-Mailer: git-send-email 2.39.5 (Apple Git-154) MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] checkasm: aacencdsp: Actually initialize ff_aac_pow34sf_tab X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This table is zero initialized by default, and has to be explicitly initialized. Coincidentally, this fixes linking checkasm with Apple's older linker. (In Xcode 15, Apple switched to a new linker. The one in older toolchains seems to have a bug where it won't figure out to load object files from a static library, if the only symbol referenced in the object file is a "common" symbol, i.e. one for a zero-initialized variable. This issue can also be reproduced with newer Apple toolchains by passing -Wl,-ld_classic to the linker.) --- tests/checkasm/aacencdsp.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/checkasm/aacencdsp.c b/tests/checkasm/aacencdsp.c index 5308a2ac03..72815bf963 100644 --- a/tests/checkasm/aacencdsp.c +++ b/tests/checkasm/aacencdsp.c @@ -67,11 +67,14 @@ static void test_abs_pow34(AACEncDSPContext *s) static void test_quant_bands(AACEncDSPContext *s) { int maxval = randomize_elem(aac_cb_maxval); - float q34 = randomize_elem(ff_aac_pow34sf_tab); + float q34; float rounding = (rnd() & 1) ? ROUND_TO_ZERO : ROUND_STANDARD; LOCAL_ALIGNED_16(float, in, [BUF_SIZE]); LOCAL_ALIGNED_16(float, scaled, [BUF_SIZE]); + ff_aac_float_common_init(); + q34 = randomize_elem(ff_aac_pow34sf_tab); + declare_func(void, int *, const float *, const float *, int, int, int, const float, const float); -- 2.39.5 (Apple Git-154) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".