Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] swscale/x86/rgb2rgb: add AVX512ICL versions of shuffle_bytes
Date: Tue, 28 Jan 2025 13:58:02 +0100
Message-ID: <20250128125802.GV4991@pb2> (raw)
In-Reply-To: <20250126064149.363420-1-16567adigashreesh@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 2206 bytes --]

On Sun, Jan 26, 2025 at 11:59:20AM +0530, Shreesh Adiga wrote:
> Signed-off-by: Shreesh Adiga <16567adigashreesh@gmail.com>
> ---
> v2: Tried to align operands and improve indentation for ASM routine.
> 
>  libswscale/x86/rgb2rgb.c     | 21 +++++++++
>  libswscale/x86/rgb_2_rgb.asm | 90 +++++++++++++++++++++++-------------
>  2 files changed, 80 insertions(+), 31 deletions(-)

fails to build here:
libswscale/x86/rgb_2_rgb.asm:141: error: invalid combination of opcode and operands
libswscale/x86/rgb_2_rgb.asm:73: ... from macro `SHUFFLE_BYTES' defined here
libswscale/x86/rgb_2_rgb.asm:142: error: invalid combination of opcode and operands
libswscale/x86/rgb_2_rgb.asm:73: ... from macro `SHUFFLE_BYTES' defined here
libswscale/x86/rgb_2_rgb.asm:143: error: invalid combination of opcode and operands
libswscale/x86/rgb_2_rgb.asm:73: ... from macro `SHUFFLE_BYTES' defined here
libswscale/x86/rgb_2_rgb.asm:144: error: invalid combination of opcode and operands
libswscale/x86/rgb_2_rgb.asm:73: ... from macro `SHUFFLE_BYTES' defined here
libswscale/x86/rgb_2_rgb.asm:145: error: invalid combination of opcode and operands
libswscale/x86/rgb_2_rgb.asm:73: ... from macro `SHUFFLE_BYTES' defined here
libswscale/x86/rgb_2_rgb.asm:146: error: invalid combination of opcode and operands
libswscale/x86/rgb_2_rgb.asm:73: ... from macro `SHUFFLE_BYTES' defined here
libswscale/x86/rgb_2_rgb.asm:147: error: invalid combination of opcode and operands
libswscale/x86/rgb_2_rgb.asm:73: ... from macro `SHUFFLE_BYTES' defined here
libswscale/x86/rgb_2_rgb.asm:148: error: invalid combination of opcode and operands
libswscale/x86/rgb_2_rgb.asm:73: ... from macro `SHUFFLE_BYTES' defined here
libswscale/x86/rgb_2_rgb.asm:149: error: invalid combination of opcode and operands
libswscale/x86/rgb_2_rgb.asm:73: ... from macro `SHUFFLE_BYTES' defined here
make: *** [ffbuild/common.mak:103: libswscale/x86/rgb_2_rgb.o] Error 1

nasm --version
NASM version 2.14.02

gcc --version
gcc (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2025-01-28 12:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-26  6:29 Shreesh Adiga
2025-01-28 12:58 ` Michael Niedermayer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250128125802.GV4991@pb2 \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git