Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Be more picky on extensions

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Be more picky on extensions
Date: Tue, 28 Jan 2025 13:14:27 +0100
Message-ID: <20250128121427.GU4991@pb2> (raw)
In-Reply-To: <CABLWnS89kGEbkWX_HDREouf5Df1FfTpzWrPXpzPBvLf+dsJtnw@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1727 bytes --]

On Tue, Jan 28, 2025 at 06:11:33AM +0100, Vittorio Giovara wrote:
> On Sat, Jan 25, 2025 at 9:38 PM Michael Niedermayer <michael@niedermayer.cc>
> wrote:
> 
> > On Thu, Jan 23, 2025 at 10:27:47PM +0100, Michael Niedermayer wrote:
> > > On Wed, Jan 22, 2025 at 09:36:09PM +0100, Michael Niedermayer wrote:
> > > > This blocks disallowed extensions from probing
> > > > It also requires all available segments to have matching extensions to
> > the format
> > > > mpegts is treated independent of the extension
> > > >
> > > > It is recommended to set the whitelists correctly
> > > > instead of depending on extensions, but this should help a bit,
> > > > and this is easier to backport
> > > >
> > > > Fixes: CVE-2023-6602 II. HLS Force TTY Demuxer
> > > > Fixes: CVE-2023-6602 IV. HLS XBIN Demuxer DoS Amplification
> > > >
> > > > The other parts of CVE-2023-6602 have been fixed by prior commits
> > > >
> > > > Found-by: Harvey Phillips of Amazon Element55 (element55)
> > > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > > > ---
> > > >  doc/demuxers.texi |  7 +++++++
> > > >  libavformat/hls.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++
> > > >  2 files changed, 57 insertions(+)
> > >
> > > I intend to apply this patchset soon so it receives some testing before
> > 7.1.1
> >
> > will apply
> >
> 
> Should this be backported to other stable releases since it's a CVE?

yes, but theres a related open regression with mpv
https://trac.ffmpeg.org/ticket/11435

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".