From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 927934CDA7 for <ffmpegdev@gitmailbox.com>; Sun, 26 Jan 2025 18:27:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B58E468BAAE; Sun, 26 Jan 2025 20:27:07 +0200 (EET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E6CE868B886 for <ffmpeg-devel@ffmpeg.org>; Sun, 26 Jan 2025 20:27:00 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 47556C0002 for <ffmpeg-devel@ffmpeg.org>; Sun, 26 Jan 2025 18:27:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1737916020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jH8dy/WepX/cjWorqvpSzCm/52c8p7mr7Pj8It9km/I=; b=keEFn09qNuNSyTw7dHt4bOczprKSs5px0CSsTyuh9aXTFLlqx1kp3P6i5IOxez/yjWvGWW aczN5vICoMe5IT4BVEGukdEyEobhcBjEb0oTpRMwhbGCSr/x+GDPtFzU+lx4K3vArX9Ety 3lU7j1pzjrN1uiGFrQ+4bkbqcCOM8jJyOEancdICibnHRpID+W3VXkGoi2sZB9bARcYePX jejZ7LFzlpO993zL+0+2eXEMRmyRKw96CGOBZESEwjnwilEGCmTlqQ9Z6Tz+M7gLjBZa3i TtWpXAJFUUaq7GEKVx5Pn9v+cAEmFBg5LrKuUhpDQZ92BbCDfey3istRcZIa1A== Date: Sun, 26 Jan 2025 19:26:59 +0100 From: Michael Niedermayer <michael@niedermayer.cc> To: ffmpeg-devel@ffmpeg.org Message-ID: <20250126182659.GE2768425@pb2> References: <20241226193325.288834126EE@natalya.videolan.org> MIME-Version: 1.0 In-Reply-To: <20241226193325.288834126EE@natalya.videolan.org> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] swscale: use 16-bit intermediate precision for RGB/XYZ conversion X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: multipart/mixed; boundary="===============5567836810446660546==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250126182659.GE2768425@pb2/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> --===============5567836810446660546== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BPjCafsbA2ap7OrL" Content-Disposition: inline --BPjCafsbA2ap7OrL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 26, 2024 at 07:33:23PM +0000, Niklas Haas wrote: > ffmpeg | branch: master | Niklas Haas <git@haasn.dev> | Mon Dec 16 14:49:= 39 2024 +0100| [af6d52eec66961f6a502b0f2f390c12226d087cd] | committer: Nikl= as Haas >=20 > swscale: use 16-bit intermediate precision for RGB/XYZ conversion >=20 > The current logic uses 12-bit linear light math, which is woefully insuff= icient > and leads to nasty postarization artifacts. This patch simply switches the > internal logic to 16-bit precision. >=20 > This raises the memory requirement of these tables from 32 kB to 272 kB. >=20 > All relevant FATE tests updated for improved accuracy. >=20 > Fixes: #4829 > Signed-off-by: Niklas Haas <git@haasn.dev> > Sponsored-by: Sovereign Tech Fund >=20 > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=3Dcommit;h=3Daf6d52eec= 66961f6a502b0f2f390c12226d087cd > --- this breaks on x86-32 grep Err fatetest make: *** [src/tests/Makefile:310: fate-filter-pixdesc-xyz12le] Error 1 make: *** [src/tests/Makefile:311: fate-filter-pixdesc-xyz12be] Error 1 make: *** [src/tests/Makefile:310: fate-pixfmt-xyz12le] Error 1 make: *** [src/tests/Makefile:311: fate-filter-pixfmts-fieldorder] Error 1 make: *** [src/tests/Makefile:310: fate-filter-pixfmts-crop] Error 1 make: *** [src/tests/Makefile:311: fate-filter-pixfmts-transpose] Error 1 make: *** [src/tests/Makefile:311: fate-filter-pixfmts-field] Error 1 make: *** [src/tests/Makefile:311: fate-filter-pixfmts-copy] Error 1 make: *** [src/tests/Makefile:310: fate-filter-pixfmts-hflip] Error 1 make: *** [src/tests/Makefile:311: fate-filter-pixfmts-il] Error 1 make: *** [src/tests/Makefile:311: fate-filter-pixfmts-null] Error 1 make: *** [src/tests/Makefile:311: fate-filter-pixfmts-vflip] Error 1 make: *** [src/tests/Makefile:311: fate-filter-pixfmts-scale] Error 1 examples: --- src/tests/ref/fate/filter-pixfmts-copy 2025-01-26 19:13:18.982388050 +0= 100 +++ tests/data/fate/filter-pixfmts-copy 2025-01-26 19:14:39.267034804 +0100 @@ -111,8 +111,8 @@ xv36le e08dcbde02f1c28a3554f372ad1278e2 xv48be ce34993b4b4411bba1d852b9b86aa39e xv48le df913a7e61b162aa98303e5393e60c63 -xyz12be f257f86373207af8aed0a1a05171df3b -xyz12le 7922f99edc44a2c26a25becbea9914cc +xyz12be d4562ab725e3ab7e5573dd03218bb03c +xyz12le ce17d867c3fea4c42324e40353b72de4 y210le 04e9487b6cce38e7531437e946cdd586 y212le 825768be8fe92708ae80be84855066ed y216le 0e99aeddfee304e72d525d72998d9e9b --- src/tests/ref/fate/filter-pixfmts-hflip 2025-01-26 19:13:18.982388050 += 0100 +++ tests/data/fate/filter-pixfmts-hflip 2025-01-26 19:14:39.275034869 +0100 @@ -108,8 +108,8 @@ xv36le e478b4b54698beb3ce1b9a2dd691d544 xv48be e030a2c7b1b600cfacb691b6e90c2e3d xv48le fbd7f8c65cd6fc9f9108dc9a1f977dc3 -xyz12be 3c50a51a3c486a0c6853e4bbbcf3f244 -xyz12le e020897d826ea20ded16f30ea1eb018d +xyz12be c678c7f19c610063f352a0253121441f +xyz12le 2320702cb1c8ccaad27d7004d4f3a195 ya16be 70fa41c32ecaf3370edc38add6096db2 ya16le 3b2c20f9e80717628ced6c6468507f63 ya8 4ad5920716de3d2fbbc49f95adb60345 Test filter-pixfmts-copy failed. Look at tests/data/fate/filter-pixfmts-cop= y.err for details. make: *** [src/tests/Makefile:311: fate-filter-pixfmts-copy] Error 1 Test filter-pixfmts-hflip failed. Look at tests/data/fate/filter-pixfmts-hf= lip.err for details. make: *** [src/tests/Makefile:310: fate-filter-pixfmts-hflip] Error 1 TEST vsynth2-mov-bgr24 TEST vsynth2-mov-bpp15 --- src/tests/ref/fate/filter-pixfmts-il 2025-01-26 19:13:18.982388050 +0100 +++ tests/data/fate/filter-pixfmts-il 2025-01-26 19:14:39.315035190 +0100 @@ -110,8 +110,8 @@ xv36le 102c0e817d375ddd6b2cfbb4262dec95 xv48be 4d7376651fb7b3e84d00abad6c785aad xv48le a1a8ff16d9a864568e5e557734bf3d6d -xyz12be b7d50e283360bf69fd661369110b26ef -xyz12le d5b1d45c3a136bb3d04f70a619c86c8d +xyz12be 3d9ae42c65eb645bb8e99dc708716f2d +xyz12le b27ec91dcff02d2b94b17c136be55001 y210le d4cf9b53cd7ff22f087743d483e88480 y212le d5a2b4677ddb4a3bc3e5cd5cbb20f426 y216le 9e44c6d76b09bcbe71738423b4b3d67a Test filter-pixfmts-il failed. Look at tests/data/fate/filter-pixfmts-il.er= r for details. make: *** [src/tests/Makefile:311: fate-filter-pixfmts-il] Error 1 TEST vsynth2-mov-bpp16 TEST vsynth2-roqvideo TEST vsynth2-rpza TEST vsynth2-smc --- src/tests/ref/fate/filter-pixfmts-null 2025-01-26 19:13:18.982388050 +0= 100 +++ tests/data/fate/filter-pixfmts-null 2025-01-26 19:14:39.451036285 +0100 @@ -111,8 +111,8 @@ xv36le e08dcbde02f1c28a3554f372ad1278e2 xv48be ce34993b4b4411bba1d852b9b86aa39e xv48le df913a7e61b162aa98303e5393e60c63 -xyz12be f257f86373207af8aed0a1a05171df3b -xyz12le 7922f99edc44a2c26a25becbea9914cc +xyz12be d4562ab725e3ab7e5573dd03218bb03c +xyz12le ce17d867c3fea4c42324e40353b72de4 y210le 04e9487b6cce38e7531437e946cdd586 y212le 825768be8fe92708ae80be84855066ed y216le 0e99aeddfee304e72d525d72998d9e9b TEST vsynth2-snow TEST vsynth2-snow-hpel Test filter-pixfmts-null failed. Look at tests/data/fate/filter-pixfmts-nul= l.err for details. make: *** [src/tests/Makefile:311: fate-filter-pixfmts-null] Error 1 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The difference between a dictatorship and a democracy is that every 4 years the population together is allowed to provide 1 bit of input to the governm= ent. --BPjCafsbA2ap7OrL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ5Z+bwAKCRBhHseHBAsP qyClAKCM8pea+xNcMJfflfGOLjNbC/twnwCgmm/BfLrcpdmGNikdYGOQsUud5B0= =kaDn -----END PGP SIGNATURE----- --BPjCafsbA2ap7OrL-- --===============5567836810446660546== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5567836810446660546==--