From: James Almer <jamrial@gmail.com> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 05/14] avutil/frame: add functions to check and ensure a side data entry is writable Date: Sat, 25 Jan 2025 17:21:33 -0300 Message-ID: <20250125202143.12126-5-jamrial@gmail.com> (raw) In-Reply-To: <20250125202143.12126-1-jamrial@gmail.com> Signed-off-by: James Almer <jamrial@gmail.com> --- libavutil/frame.h | 19 ++++++++++++++++++ libavutil/side_data.c | 45 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+) diff --git a/libavutil/frame.h b/libavutil/frame.h index 019adaac0e..aa4e619ad2 100644 --- a/libavutil/frame.h +++ b/libavutil/frame.h @@ -1207,6 +1207,25 @@ void av_frame_side_data_remove(AVFrameSideData ***sd, int *nb_sd, void av_frame_side_data_remove_by_props(AVFrameSideData ***sd, int *nb_sd, int props); +/** + * Check whether the data described by a given AVFrameSideData can be + * written to. + * + * @return 1 if the caller may write to the data, 0 otherwise. + */ +int av_frame_side_data_is_writable(const AVFrameSideData *sd); + +/** + * Create a writable reference for the data described by a given + * AVFrameSideData, avoiding data copy if possible. + * + * @param sd Side data whose data should be made writable. + * + * @return 0 on success, a negative AVERROR on failure. On failure, the + * side data is unchanged. + */ +int av_frame_side_data_make_writable(AVFrameSideData *sd); + /** * @} */ diff --git a/libavutil/side_data.c b/libavutil/side_data.c index 7be1c346cd..8fb9dfed2b 100644 --- a/libavutil/side_data.c +++ b/libavutil/side_data.c @@ -369,3 +369,48 @@ const AVFrameSideData *av_frame_side_data_get_c(const AVFrameSideData * const *s } return NULL; } + +int av_frame_side_data_is_writable(const AVFrameSideData *sd) +{ +#if FF_API_SIDE_DATA_BUF +FF_DISABLE_DEPRECATION_WARNINGS + return !!av_buffer_is_writable(sd->buf); +#else + const FFFrameSideData *sdp = csdp_from_sd(sd); + return !!av_buffer_is_writable(sdp->buf); +#endif +} + +int av_frame_side_data_make_writable(AVFrameSideData *sd) +{ + FFFrameSideData *sdp = sdp_from_sd(sd); + AVBufferRef *buf = NULL; + +#if FF_API_SIDE_DATA_BUF +FF_DISABLE_DEPRECATION_WARNINGS + if (av_buffer_is_writable(sd->buf)) +FF_ENABLE_DEPRECATION_WARNINGS +#else + if (av_buffer_is_writable(sdp->buf)) +#endif + return 0; + + buf = av_buffer_alloc(sd->size); + if (!buf) + return AVERROR(ENOMEM); + + if (sd->size) + memcpy(buf->data, sd->data, sd->size); +#if FF_API_SIDE_DATA_BUF +FF_DISABLE_DEPRECATION_WARNINGS + av_buffer_unref(&sd->buf); + sd->buf = buf; +FF_ENABLE_DEPRECATION_WARNINGS +#else + av_buffer_unref(&sdp->buf); + sdp->buf = buf; +#endif + sd->data = buf->data; + + return 0; +} -- 2.48.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-01-25 20:22 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-01-25 20:21 [FFmpeg-devel] [PATCH 01/14] avutil/frame: move side data helpers to a new file James Almer 2025-01-25 20:21 ` [FFmpeg-devel] [PATCH 02/14] avutil/frame: allow the addition of internal fields to AVSideDataDescriptor James Almer 2025-01-25 20:21 ` [FFmpeg-devel] [PATCH 03/14] avutil/frame: allow the addition of internal fields to AVFrameSideData James Almer 2025-01-25 20:21 ` [FFmpeg-devel] [PATCH 04/14] avutil/frame: schedule making AVFrameSideData.buf internal James Almer 2025-01-25 20:21 ` James Almer [this message] 2025-01-25 20:21 ` [FFmpeg-devel] [PATCH 06/14] avutil/frame: av_frame_side_data_new_struct() James Almer 2025-01-25 20:21 ` [FFmpeg-devel] [PATCH 07/14] avutil/frame: add support for RefStruct as backing for side data James Almer 2025-01-25 20:21 ` [FFmpeg-devel] [PoC][PATCH 08/14] avutil/frame: add a param change side data type James Almer 2025-01-29 12:29 ` Andreas Rheinhardt 2025-01-29 13:53 ` James Almer 2025-01-25 20:21 ` [FFmpeg-devel] [PATCH 09/14] avutil/ambient_viewing_environment: deprecate av_ambient_viewing_environment_create_side_data() James Almer 2025-01-25 20:21 ` [FFmpeg-devel] [PATCH 10/14] avutil/downmix_info: deprecate av_downmix_info_update_side_data() James Almer 2025-01-25 20:21 ` [FFmpeg-devel] [PATCH 11/14] avutil/hdr_dynamic_metadata: deprecate av_dynamic_hdr_plus_create_side_data() James Almer 2025-01-25 20:21 ` [FFmpeg-devel] [PATCH 12/14] avutil/hdr_dynamic_vivid_metadata: deprecate av_dynamic_hdr_vivid_create_side_data() James Almer 2025-01-25 20:21 ` [FFmpeg-devel] [PATCH 13/14] avutil/mastering_display_metadata: deprecate av_{content_light, mastering_display_metadata}_create_side_data() James Almer 2025-01-25 20:21 ` [FFmpeg-devel] [PATCH 14/14] avutil/stereo3d: deprecate av_stereo3d_create_side_data() James Almer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20250125202143.12126-5-jamrial@gmail.com \ --to=jamrial@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git