[FFmpeg-devel] [PATCH] avformat/id3v2: add image/webp for WebP attached pictures

[FFmpeg-devel] [PATCH] avformat/id3v2: add image/webp for WebP attached pictures

[Jan Ekström]

Found out to have been utilized via a user reporting an attached
image not being available in a player utilizing avformat's demuxing
capabilities.
---
 libavformat/id3v2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c
index 3507885706..29ee59e1f4 100644
--- a/libavformat/id3v2.c
+++ b/libavformat/id3v2.c
@@ -137,6 +137,7 @@ const CodecMime ff_id3v2_mime_tags[] = {
     { "image/png",  AV_CODEC_ID_PNG   },
     { "image/tiff", AV_CODEC_ID_TIFF  },
     { "image/bmp",  AV_CODEC_ID_BMP   },
+    { "image/webp", AV_CODEC_ID_WEBP  },
     { "JPG",        AV_CODEC_ID_MJPEG }, /* ID3v2.2  */
     { "PNG",        AV_CODEC_ID_PNG   }, /* ID3v2.2  */
     { "",           AV_CODEC_ID_NONE  },
-- 
2.48.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/id3v2: add image/webp for WebP attached pictures

[Jan Ekström]

On Sat, Jan 25, 2025 at 9:38 PM Jan Ekström <jeebjp@gmail.com> wrote:
>
> Found out to have been utilized via a user reporting an attached
> image not being available in a player utilizing avformat's demuxing
> capabilities.
> ---

Asked around in the audio player circles of foobar2000, and these sort
of files seem to indeed exist as the author of that player also has
them in their test suite.

Thus, unless there are any objections I'll apply this tomorrow or so
as this block seems to do what's expected and attached images are now
properly exposed.

Best regards,
Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/id3v2: add image/webp for WebP attached pictures

[Jan Ekström]

On Mon, Jan 27, 2025 at 9:56 PM Jan Ekström <jeebjp@gmail.com> wrote:
>
> On Sat, Jan 25, 2025 at 9:38 PM Jan Ekström <jeebjp@gmail.com> wrote:
> >
> > Found out to have been utilized via a user reporting an attached
> > image not being available in a player utilizing avformat's demuxing
> > capabilities.
> > ---
>
> Asked around in the audio player circles of foobar2000, and these sort
> of files seem to indeed exist as the author of that player also has
> them in their test suite.
>
> Thus, unless there are any objections I'll apply this tomorrow or so
> as this block seems to do what's expected and attached images are now
> properly exposed.

Applied to master as 4401e4b6065ea33d422adaa58692c5a4ba0ec2a4 .

Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".