From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 8AEB94C711 for ; Sat, 25 Jan 2025 00:46:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1F24C68B657; Sat, 25 Jan 2025 02:46:53 +0200 (EET) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 21AF368A778 for ; Sat, 25 Jan 2025 02:46:46 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 3D0111BF204 for ; Sat, 25 Jan 2025 00:46:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1737766006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MxIPy+z0venbOL60hDbIS6GT8YKeACdAqmG0Fyanr8Y=; b=dHkYosG6WMPldnaNZQM3plIQQ7jWuPJoHSqa4Rgv3qcZjuHlA6ClCT3P2hQFVPDKvCrDoK d+gjVlpUNF6kZ+Et5l/dTb76OeaqSXnJlYLFTBpz86F+0KcbkhTDuUvj7Ex24Ql+joqVzZ PBCN1FrhiiBtyt06nTOdN6dME61WUdP5oBA809577jCuWPh/LB5Z1iVcmKxfextU5l9C1+ 8pbsWgFJBp/1C3WBIos3LZfOIttrM16VPnWMRuk5eFWooQamX3G+eAiCKT/ZvTJr8udXjT sXEayNbMKJDA8Lu1ULxl0q/NVzWa1UnbO5vhlMyc0V/N7KkEV+SzfzHhleF4/Q== Date: Sat, 25 Jan 2025 01:46:45 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250125004645.GF4991@pb2> References: <20250117204315.GO4991@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat: add DAT (Digital Audio Tape) demuxer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0864442094263825357==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0864442094263825357== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GVcPUA8K/7mZoD95" Content-Disposition: inline --GVcPUA8K/7mZoD95 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 22, 2025 at 12:26:17PM +0100, Jerome Martinez wrote: > Le 17/01/2025 =E0 21:43, Michael Niedermayer a =E9crit=A0: > > On Fri, Jan 17, 2025 at 12:38:02PM +0100, Jerome Martinez wrote: > > > [...] > > > Subject: [PATCH] avformat: add DAT demuxer > > breaks fate-cdxl-pal8-small > >=20 > > I guess the probe function is not working as expected >=20 > cdxl parser provides a read_probe value of 1, difficult to compete there.= =2E. > I added checks on extra metadata (not needed for decoding) for having a D= AT > parser read_probe value of 0 for the cdxl-pal8-small file, it works with = all > the DAT files I found while not changing the fate tests behavior. > Attached is an 2/2 patch to be added to the first one, I separate the fix > patch from the initial patch in order to keep author name of each patch. > dat.c | 41 ++++++++++++++++++++++++++++++++++------- > 1 file changed, 34 insertions(+), 7 deletions(-) > 9dbe3c927caa58e9dd3b9b78fb2ca478380b5f98 0002-avformat-improve-DAT-demux= er-read_probe.patch > From 17e4ae0189fc60e4c69357b5324fd84b111a0ac3 Mon Sep 17 00:00:00 2001 > From: Jerome Martinez > Date: Tue, 21 Jan 2025 22:31:31 +0100 > Subject: [PATCH 2/2] avformat: improve DAT demuxer read_probe" this passes tests. but if you want, you could instead of testing "extra metadata (not needed f= or decoding)" test more than 1 packet having a best case score of 1 seems to be something that will likely fail sooner or later by not detecting a dat file thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The difference between a dictatorship and a democracy is that every 4 years the population together is allowed to provide 1 bit of input to the governm= ent. --GVcPUA8K/7mZoD95 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ5Q0cQAKCRBhHseHBAsP q9RhAJwJT7noHeiCrG6IvyiVOJ7/cY9eTgCfckt5pPdl3dc7ylOppy2T17lKJaw= =M83M -----END PGP SIGNATURE----- --GVcPUA8K/7mZoD95-- --===============0864442094263825357== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0864442094263825357==--