Re: [FFmpeg-devel] [PATCH] avformat: add DAT (Digital Audio Tape) demuxer

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1773 bytes --]

On Wed, Jan 22, 2025 at 12:26:17PM +0100, Jerome Martinez wrote:
> Le 17/01/2025 à 21:43, Michael Niedermayer a écrit :
> > On Fri, Jan 17, 2025 at 12:38:02PM +0100, Jerome Martinez wrote:
> > > [...]
> > > Subject: [PATCH] avformat: add DAT demuxer
> > breaks fate-cdxl-pal8-small
> > 
> > I guess the probe function is not working as expected
> 
> cdxl parser provides a read_probe value of 1, difficult to compete there...
> I added checks on extra metadata (not needed for decoding) for having a DAT
> parser read_probe value of 0 for the cdxl-pal8-small file, it works with all
> the DAT files I found while not changing the fate tests behavior.
> Attached is an 2/2 patch to be added to the first one, I separate the fix
> patch from the initial patch in order to keep author name of each patch.

>  dat.c |   41 ++++++++++++++++++++++++++++++++++-------
>  1 file changed, 34 insertions(+), 7 deletions(-)
> 9dbe3c927caa58e9dd3b9b78fb2ca478380b5f98  0002-avformat-improve-DAT-demuxer-read_probe.patch
> From 17e4ae0189fc60e4c69357b5324fd84b111a0ac3 Mon Sep 17 00:00:00 2001
> From: Jerome Martinez <jerome@mediaarea.net>
> Date: Tue, 21 Jan 2025 22:31:31 +0100
> Subject: [PATCH 2/2] avformat: improve DAT demuxer read_probe"

this passes tests.

but if you want, you could instead of testing "extra metadata (not needed for decoding)"
test more than 1 packet

having a best case score of 1 seems to be something that will
likely fail sooner or later by not detecting a dat file

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The difference between a dictatorship and a democracy is that every 4 years
the population together is allowed to provide 1 bit of input to the government.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".