Re: [FFmpeg-devel] [FFmpeg-cvslog] ffv1dec: use dedicated pix_fmt field and call ff_get_format

Re: [FFmpeg-devel] [FFmpeg-cvslog] ffv1dec: use dedicated pix_fmt field and call ff_get_format

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1161 bytes --]

On Tue, Jan 21, 2025 at 03:10:47PM +0000, Lynne wrote:
> ffmpeg | branch: master | Lynne <dev@lynne.ee> | Sun Jan  5 13:42:47 2025 +0900| [7187eadf8c0f0c640f1d23811c55fad0cba60aa5] | committer: Lynne
> 
> ffv1dec: use dedicated pix_fmt field and call ff_get_format
> 
> Adding support for hwaccels means that avctx->pix_fmt will indicate
> hardware formats.
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=7187eadf8c0f0c640f1d23811c55fad0cba60aa5
> ---
> 
>  libavcodec/ffv1.h    |   1 +
>  libavcodec/ffv1dec.c | 140 ++++++++++++++++++++++++++++-----------------------
>  2 files changed, 78 insertions(+), 63 deletions(-)

breaks:
./ffmpeg -y  -i mm-short.mpg -an -vcodec ffv1 -slices 4 -t 1 -coder 1 -level 3 -slicecrc 0 -context 0 -pix_fmt ya8 -bitexact out.nut
./ffplay out.nut

(and others)
slices seem to decode in the wrong locations and jump randomly around

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The difference between a dictatorship and a democracy is that every 4 years
the population together is allowed to provide 1 bit of input to the government.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] ffv1dec: use dedicated pix_fmt field and call ff_get_format

[Lynne]

[-- Attachment #1.1.1.1: Type: text/plain, Size: 1081 bytes --]



On 25/01/2025 06:54, Michael Niedermayer wrote:
> On Tue, Jan 21, 2025 at 03:10:47PM +0000, Lynne wrote:
>> ffmpeg | branch: master | Lynne <dev@lynne.ee> | Sun Jan  5 13:42:47 2025 +0900| [7187eadf8c0f0c640f1d23811c55fad0cba60aa5] | committer: Lynne
>>
>> ffv1dec: use dedicated pix_fmt field and call ff_get_format
>>
>> Adding support for hwaccels means that avctx->pix_fmt will indicate
>> hardware formats.
>>
>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=7187eadf8c0f0c640f1d23811c55fad0cba60aa5
>> ---
>>
>>   libavcodec/ffv1.h    |   1 +
>>   libavcodec/ffv1dec.c | 140 ++++++++++++++++++++++++++++-----------------------
>>   2 files changed, 78 insertions(+), 63 deletions(-)
> 
> breaks:
> ./ffmpeg -y  -i mm-short.mpg -an -vcodec ffv1 -slices 4 -t 1 -coder 1 -level 3 -slicecrc 0 -context 0 -pix_fmt ya8 -bitexact out.nut
> ./ffplay out.nut
> 
> (and others)
> slices seem to decode in the wrong locations and jump randomly around
> 
> thx

Thanks.
Is it this specific patch, or is it the patchset as a whole that did it?

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] ffv1dec: use dedicated pix_fmt field and call ff_get_format

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1642 bytes --]

Hi Lynne

On Sat, Jan 25, 2025 at 11:06:43AM +0900, Lynne wrote:
> 
> 
> On 25/01/2025 06:54, Michael Niedermayer wrote:
> > On Tue, Jan 21, 2025 at 03:10:47PM +0000, Lynne wrote:
> > > ffmpeg | branch: master | Lynne <dev@lynne.ee> | Sun Jan  5 13:42:47 2025 +0900| [7187eadf8c0f0c640f1d23811c55fad0cba60aa5] | committer: Lynne
> > > 
> > > ffv1dec: use dedicated pix_fmt field and call ff_get_format
> > > 
> > > Adding support for hwaccels means that avctx->pix_fmt will indicate
> > > hardware formats.
> > > 
> > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=7187eadf8c0f0c640f1d23811c55fad0cba60aa5
> > > ---
> > > 
> > >   libavcodec/ffv1.h    |   1 +
> > >   libavcodec/ffv1dec.c | 140 ++++++++++++++++++++++++++++-----------------------
> > >   2 files changed, 78 insertions(+), 63 deletions(-)
> > 
> > breaks:
> > ./ffmpeg -y  -i mm-short.mpg -an -vcodec ffv1 -slices 4 -t 1 -coder 1 -level 3 -slicecrc 0 -context 0 -pix_fmt ya8 -bitexact out.nut
> > ./ffplay out.nut
> > 
> > (and others)
> > slices seem to decode in the wrong locations and jump randomly around
> > 
> > thx
> 
> Thanks.
> Is it this specific patch, or is it the patchset as a whole that did it?

bisect pointed to this patch
and reverting it and the following patches fixes it

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".