* Re: [FFmpeg-devel] [PATCH 2/7] avformat/mxfdec: Check avio_read() success in mxf_decrypt_triplet()
[not found] ` <689686e2e5bf3d1aad0da4f114741c2190730c8e.camel@haerdin.se>
@ 2025-01-21 18:09 ` Michael Niedermayer
0 siblings, 0 replies; only message in thread
From: Michael Niedermayer @ 2025-01-21 18:09 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1.1: Type: text/plain, Size: 1449 bytes --]
On Tue, Sep 24, 2024 at 06:58:31PM +0200, Tomas Härdin wrote:
> mån 2024-09-23 klockan 23:32 +0200 skrev Michael Niedermayer:
> > Fixes: Use of uninitialized memory
> > Fixes: 71444/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-
> > 5448597561212928
> >
> > Found-by: continuous fuzzing process
> > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> > libavformat/mxfdec.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> > index 24f4ed1c33d..b232c45f47d 100644
> > --- a/libavformat/mxfdec.c
> > +++ b/libavformat/mxfdec.c
> > @@ -671,7 +671,8 @@ static int mxf_decrypt_triplet(AVFormatContext
> > *s, AVPacket *pkt, KLVPacket *klv
> > if (size < 32 || size - 32 < orig_size || (int)orig_size !=
> > orig_size)
> > return AVERROR_INVALIDDATA;
> > avio_read(pb, ivec, 16);
> > - avio_read(pb, tmpbuf, 16);
> > + if (avio_read(pb, tmpbuf, 16) != 16)
> > + return AVERROR_INVALIDDATA;
>
> I get the feeling mxfdec has a whole bunch of these..
yeah, and i have even forgotten to apply this one
will apply it now at least
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] only message in thread