From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 2612D4B4B6 for ; Tue, 21 Jan 2025 18:10:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 569DD68B672; Tue, 21 Jan 2025 20:09:58 +0200 (EET) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3797168B1A1 for ; Tue, 21 Jan 2025 20:09:51 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 92D2C40002 for ; Tue, 21 Jan 2025 18:09:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1737482990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FiFetVdSt9oEFG70/8QjRVzeQa1QbiQ/Bm/G/+I88sc=; b=RANv8YCU11DFxZTSdLJ+xmmWb59++20htCAqQ+bMlI/87a/bz0u9QYE7yV0BpEaVfwtOFe vo3Q9KznZu7uzXn2+cieYjPunC+57UkBMGGAmzjovPKAJzvJxY2lvRozvOe9Krj+Cu1GuA 8PtKykzGYgSqOw6CUg2ZDk8ofBUkhk65hLU4eKvk+DJHJE0ZfBOkFP4F1AxFs1kLlclYpp uvGxeyzL7X5+aggzx4T12qpQu7taqgLLGcMLsfnNrl7eDZO4BPzFsN+SqNBIeZKOCgHViy wfHWeoxriieDZarH2FT9mzkK4/wuHJa7uhmEK8usob4r3BFo5oqp5pva5rXyAA== Date: Tue, 21 Jan 2025 19:09:49 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250121180949.GR4991@pb2> References: <20240923213249.3256534-1-michael@niedermayer.cc> <20240923213249.3256534-2-michael@niedermayer.cc> <689686e2e5bf3d1aad0da4f114741c2190730c8e.camel@haerdin.se> MIME-Version: 1.0 In-Reply-To: <689686e2e5bf3d1aad0da4f114741c2190730c8e.camel@haerdin.se> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 2/7] avformat/mxfdec: Check avio_read() success in mxf_decrypt_triplet() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0436191269883691362==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0436191269883691362== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cGtjM5AW2XDXB9mr" Content-Disposition: inline --cGtjM5AW2XDXB9mr Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 24, 2024 at 06:58:31PM +0200, Tomas H=E4rdin wrote: > m=E5n 2024-09-23 klockan 23:32 +0200 skrev Michael Niedermayer: > > Fixes: Use of uninitialized memory > > Fixes: 71444/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer- > > 5448597561212928 > >=20 > > Found-by: continuous fuzzing process > > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > =A0libavformat/mxfdec.c | 3 ++- > > =A01 file changed, 2 insertions(+), 1 deletion(-) > >=20 > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > > index 24f4ed1c33d..b232c45f47d 100644 > > --- a/libavformat/mxfdec.c > > +++ b/libavformat/mxfdec.c > > @@ -671,7 +671,8 @@ static int mxf_decrypt_triplet(AVFormatContext > > *s, AVPacket *pkt, KLVPacket *klv > > =A0=A0=A0=A0 if (size < 32 || size - 32 < orig_size || (int)orig_size != =3D > > orig_size) > > =A0=A0=A0=A0=A0=A0=A0=A0 return AVERROR_INVALIDDATA; > > =A0=A0=A0=A0 avio_read(pb, ivec, 16); > > -=A0=A0=A0 avio_read(pb, tmpbuf, 16); > > +=A0=A0=A0 if (avio_read(pb, tmpbuf, 16) !=3D 16) > > +=A0=A0=A0=A0=A0=A0=A0 return AVERROR_INVALIDDATA; >=20 > I get the feeling mxfdec has a whole bunch of these.. yeah, and i have even forgotten to apply this one will apply it now at least [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is dangerous to be right in matters on which the established authorities are wrong. -- Voltaire --cGtjM5AW2XDXB9mr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ4/i7QAKCRBhHseHBAsP q5d5AJ9I9mXjPthUOohmn4qHHNV2f6eDfwCeKqLHYRzTHEuSBHZqk53Nj9RzDeU= =DU1H -----END PGP SIGNATURE----- --cGtjM5AW2XDXB9mr-- --===============0436191269883691362== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0436191269883691362==--