From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 265184AEDE for ; Tue, 21 Jan 2025 17:25:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6E9EA68B404; Tue, 21 Jan 2025 19:25:31 +0200 (EET) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7D62068B3A5 for ; Tue, 21 Jan 2025 19:25:24 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id B916DFF802 for ; Tue, 21 Jan 2025 17:25:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1737480323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LG8Vb0tUQwKVr8mVUBsFOU0MOVUK0N4ZQZkVUw0bBPg=; b=QzCH73yWgJQ4D+CvZItvkwQD3siR+5nc8Av2FGFdn9ikQD+8VlrTQHk71OLHDCCuwco9Ru LdpQiRC5jGoL/j4RZPxWU/NXmi5p0l+HBVgTpfugVDgG3ndUkXAUc/uOIsgpnmPwzjMxdw FzZmRpbEEe7bKx5CDW6gK1WCqAiY40N6NEgdUTFR1UP8KWn9G2hqJOguZW4alXBHKWidec SvTVZVo7b3TMnwMn67CtYFu5S50PD8MrZEy6V4vgwBuPItkyWnMyUK3T5i/Lzqzv4U2lhU w8EUxBjGhllYp4RPFweNS0Y7b0RAzwdtVnUR1X5LOAoTzKsBblsVwLZjMtsHUg== Date: Tue, 21 Jan 2025 18:25:22 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250121172522.GJ4991@pb2> References: <20250116132307.1907951-1-michael@niedermayer.cc> <20250116133739.GG4991@pb2> MIME-Version: 1.0 In-Reply-To: <20250116133739.GG4991@pb2> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/hls: Be more picky on extensions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7823296370380342620==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7823296370380342620== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9sHF6ZR0zEb4Xl/U" Content-Disposition: inline --9sHF6ZR0zEb4Xl/U Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 16, 2025 at 02:37:39PM +0100, Michael Niedermayer wrote: > Hi all >=20 > On Thu, Jan 16, 2025 at 02:23:07PM +0100, Michael Niedermayer wrote: > > This blocks disallowed extensions from probing > > It also requires all available segments to have matching extensions to = the format > >=20 > > It is recommended to set the whitelists correctly > > instead of depending on extensions, but this should help a bit, > > and this is easier to backport > >=20 > > Fixes: CVE-2023-6602 II. HLS Force TTY Demuxer > > Fixes: CVE-2023-6602 IV. HLS XBIN Demuxer DoS Amplification > >=20 > > The other parts of CVE-2023-6602 have been fixed by prior commits > >=20 > > Found-by: Harvey Phillips of Amazon Element55 (element55) > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/hls.c | 48 +++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 48 insertions(+) >=20 > If someone has a testcase that after playback starts, adds cases to the > list, please test that. I have no testcase for that and thus did not > test if the newly added tests behave correctly for that. noone cares, ok, cant just leave security fixes unapplied will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Old school: Use the lowest level language in which you can solve the problem conveniently. New school: Use the highest level language in which the latest supercomputer can solve the problem without the user falling asleep waiting. --9sHF6ZR0zEb4Xl/U Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ4/YfwAKCRBhHseHBAsP q7c+AJ0cX3AO2w/djdZowcjz8fB+KEEdaQCfb5ypJAP/CYH0JgDRZGQA/VbnsV8= =fR62 -----END PGP SIGNATURE----- --9sHF6ZR0zEb4Xl/U-- --===============7823296370380342620== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7823296370380342620==--