From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 54B714AE60 for ; Tue, 21 Jan 2025 17:05:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7417568B672; Tue, 21 Jan 2025 19:05:44 +0200 (EET) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 78AD268AFCB for ; Tue, 21 Jan 2025 19:05:38 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id AA5A51C0005 for ; Tue, 21 Jan 2025 17:05:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1737479137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I/8IYFSD9if9tktzCZN4SPzcWVlhqL4xfLLxN4iQy1I=; b=oIzw9dC/T3WvYDC0rxrnwo+fyvM0ov/co30twvBChvgUnkHV048x4+Cixazdh8STM5rA+L MWySOyTN1VsfzLN2lFvYHpP6uV3yfADznwdurqQEb8Tdv3wnCWNA81/dEkFekoiECwTPs+ iFNkWtsBIGDvOTStHAioHxXOm4lfzT6Rw5BfucNSHrPnA35a7k9YjiuS062XQn2ZsWOTbf V6WanFCgeRzOy4dOCqhVyLWOA0aTl/iRuE0ew0US96JA0EuW/adzq9DKIFzfgdEKAcao8H +T+F8LAypJR8G08+wMbajAvDVmHfsox2LPopaLurLTiYgA+7SxRyMYXS4KWBKQ== Date: Tue, 21 Jan 2025 18:05:37 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250121170537.GI4991@pb2> References: <20250110040614.2776189-1-michael@niedermayer.cc> <20250110040614.2776189-4-michael@niedermayer.cc> <20250111020247.GN4991@pb2> MIME-Version: 1.0 In-Reply-To: <20250111020247.GN4991@pb2> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 4/5] swscale: 16bit planar float input support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2554990730199150341==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2554990730199150341== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EaFFKSLiJbPmroB7" Content-Disposition: inline --EaFFKSLiJbPmroB7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 11, 2025 at 03:02:47AM +0100, Michael Niedermayer wrote: > On Fri, Jan 10, 2025 at 05:06:13AM +0100, Michael Niedermayer wrote: > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libswscale/input.c | 97 +++++++++++++++++++++++++++++++++++ > > libswscale/swscale_unscaled.c | 2 +- > > libswscale/utils.c | 8 +++ > > 3 files changed, 106 insertions(+), 1 deletion(-) > [...] >=20 > > diff --git a/libswscale/swscale_unscaled.c b/libswscale/swscale_unscale= d.c > > index dae3f45df9e..541cd159c74 100644 > > --- a/libswscale/swscale_unscaled.c > > +++ b/libswscale/swscale_unscaled.c > > @@ -2659,7 +2659,7 @@ void ff_get_unscaled_swscale(SwsInternal *c) > > if ( srcFormat =3D=3D dstFormat || > > (srcFormat =3D=3D AV_PIX_FMT_YUVA420P && dstFormat =3D=3D AV_P= IX_FMT_YUV420P) || > > (srcFormat =3D=3D AV_PIX_FMT_YUV420P && dstFormat =3D=3D AV_PI= X_FMT_YUVA420P) || > > - (isFloat(srcFormat) =3D=3D isFloat(dstFormat)) && ((isPlanarYU= V(srcFormat) && isPlanarGray(dstFormat)) || > > + (isFloat(srcFormat) =3D=3D isFloat(dstFormat) && c->srcFormatB= pp =3D=3D c->dstFormatBpp) && ((isPlanarYUV(srcFormat) && isPlanarGray(dstF= ormat)) || >=20 > This is wrong, fixed locally will apply this and the prerequesit pixfmt addition [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unrelated to the bug with no further explanation, that is a good sign that the bugfix is wrong. --EaFFKSLiJbPmroB7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ4/T3QAKCRBhHseHBAsP q3XHAJ0aUnl/iJPBSAXzPX1UjhRmqWHrUQCfbAWrHuyOztLh+xMLII4dVm8C+NE= =s5yl -----END PGP SIGNATURE----- --EaFFKSLiJbPmroB7-- --===============2554990730199150341== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2554990730199150341==--