From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 83B4E4AB3F for ; Tue, 21 Jan 2025 12:00:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1B35D68B404; Tue, 21 Jan 2025 14:00:23 +0200 (EET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 38ADA68AFCB for ; Tue, 21 Jan 2025 14:00:17 +0200 (EET) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-21661be2c2dso96809505ad.1 for ; Tue, 21 Jan 2025 04:00:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737460815; x=1738065615; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=E/eou+NMZIhpHOdw6OBF4WQG3v3ppgU0avPVFxX9o4Y=; b=bO/fRTW8JVEi+iL0k+pdFigqEaTu9OnjSWolGALCQbwSNfFjJNiTL9j7fVAiCtjPvN lfjuZHJq0DVeHDmuQ2x3Mg0GRpYnIInSyZyjlpwfkSO9E7+Iydye78mmpp0qA+8Omnah iP7mdy5X7uAW+B6Thu36wP+1CIa+nt3qX1kxCTNMm1rk7k5aOqtbBV1PryiadSbMVWNw 7kfUfKkfBAPi0ewcerrbNXWM/stV7nfI19Jca4aKhv1KAahhA5ccBJwtRLpngZ36J5jp CnI8z+rvTdYk+27OhI1urbPDZkFjgR0gGzarMLA7vCcGRDKpJu7+9ZoFl6UqbSeKJVKN ITcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737460815; x=1738065615; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=E/eou+NMZIhpHOdw6OBF4WQG3v3ppgU0avPVFxX9o4Y=; b=hixbhdw7a4Ndbr3oJkoAxGaFSJYErzJ0Jta1iYfcVrK1Ke/1ar4RfwqD58VtmZUV3C t7VVdj2fHiUHBPG0JSEzuQ+t337xzZt5iytZtZqOTMEHqchHfAAvL0KeoL/c6t/2msQX qrV+aJTaT7I9OK92wB6HaHgEqj8JA3OWz5SQD+aXHgXtQoeWYp6J1y8XcOD4F3ZL/Pya 5rJFK6Vy0mgu92Scc4dDGwBoMKVL4AbWGi8gSLolKvE7lMM2+s29V1hsDZ/ttKKKJcBf +2IY1bKvYUNFtwtTRWy1j8WaEN1wcl4oDTwaSxrD6cldslALj5rj+MH60d3Iusj0amVt yaXQ== X-Gm-Message-State: AOJu0YwV/7O4niZusC5Ih6y0w67MJu9L3mpNDhpe1CTkCJWEeuOwGKYP wX9RodjM47qMFUL48wRmC7/ttJfBEOeTihfbPCG0vLfNPH0UsRKvwJm0+w== X-Gm-Gg: ASbGncuiu37AWYbichUH+QFRA2guXukvMPZw6vtR4VzzFdlzdaVNYowndZakzb1fPXi tP1ymf+qHZoVl30LkfWGPQQSi+Rgtv6Mp/phQKXDmYlPI38KsSfiX42oi3DYnUpPAQIrs5NvA0u vGMPSMfoQwDdrhSPdF9UajakwZPTf2TwhadqzGUvISLFzYf8+0MeqgVYyiLfWXxLOIetKCk7Fj2 +TPHJROXDAihYthpaFbCmS/RvMRHE72P46dJLbtIv4/voELUPcFzDZkFlK7I0OE6ZCu4rIMWoF/ hhphBcHfJZ8v6YoX X-Google-Smtp-Source: AGHT+IFH2/Cns0UdxlG9VyKtC14QL89+wVhtBOxb+GEwHvVe3pDi9iZkvL+zozjPu3rGT5rfGodMlA== X-Received: by 2002:a05:6a20:4309:b0:1e1:a693:d623 with SMTP id adf61e73a8af0-1eb214ea886mr24966761637.25.1737460815049; Tue, 21 Jan 2025 04:00:15 -0800 (PST) Received: from localhost.localdomain ([2401:4900:51ca:8e8f:6ee9:5af5:3873:575d]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72dab9c8e89sm8951106b3a.109.2025.01.21.04.00.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2025 04:00:14 -0800 (PST) From: Viraaj Raulgaonkar To: ffmpeg-devel@ffmpeg.org Date: Tue, 21 Jan 2025 17:30:05 +0530 Message-Id: <20250121120005.509005-1-viraajraulgkar@gmail.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avformat/riffdec: remove invalid sample rate check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Viraaj Raulgaonkar Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Sample rates up to 2^31 - 1 are considered valid, while greater values are invalid. Removing the check potentially allows the sample rate to be decoded in all cases instead of halting demux for values greater than 2^31 - 1. Fixes Trac ticket #11361. --- libavformat/riffdec.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/libavformat/riffdec.c b/libavformat/riffdec.c index b7a85a6ab2..94dccb324e 100644 --- a/libavformat/riffdec.c +++ b/libavformat/riffdec.c @@ -179,11 +179,6 @@ int ff_get_wav_header(void *logctx, AVIOContext *pb, par->bit_rate = bitrate; - if (par->sample_rate <= 0) { - av_log(logctx, AV_LOG_ERROR, - "Invalid sample rate: %d\n", par->sample_rate); - return AVERROR_INVALIDDATA; - } if (par->codec_id == AV_CODEC_ID_AAC_LATM) { /* Channels and sample_rate values are those prior to applying SBR * and/or PS. */ -- 2.39.5 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".