From: Viraaj Raulgaonkar <viraajraulgkar@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Viraaj Raulgaonkar <viraajraulgkar@gmail.com>
Subject: [FFmpeg-devel] [PATCH] avformat/riffdec: remove invalid sample rate check
Date: Tue, 21 Jan 2025 17:30:05 +0530
Message-ID: <20250121120005.509005-1-viraajraulgkar@gmail.com> (raw)
Sample rates up to 2^31 - 1 are considered valid, while greater values
are invalid. Removing the check potentially allows the sample rate
to be decoded in all cases instead of halting demux for values
greater than 2^31 - 1.
Fixes Trac ticket #11361.
---
libavformat/riffdec.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/libavformat/riffdec.c b/libavformat/riffdec.c
index b7a85a6ab2..94dccb324e 100644
--- a/libavformat/riffdec.c
+++ b/libavformat/riffdec.c
@@ -179,11 +179,6 @@ int ff_get_wav_header(void *logctx, AVIOContext *pb,
par->bit_rate = bitrate;
- if (par->sample_rate <= 0) {
- av_log(logctx, AV_LOG_ERROR,
- "Invalid sample rate: %d\n", par->sample_rate);
- return AVERROR_INVALIDDATA;
- }
if (par->codec_id == AV_CODEC_ID_AAC_LATM) {
/* Channels and sample_rate values are those prior to applying SBR
* and/or PS. */
--
2.39.5
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2025-01-21 12:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 12:00 Viraaj Raulgaonkar [this message]
2025-01-25 1:19 ` Michael Niedermayer
2025-01-25 1:26 ` Michael Niedermayer
2025-01-26 10:42 ` Viraaj Raulgaonkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250121120005.509005-1-viraajraulgkar@gmail.com \
--to=viraajraulgkar@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git