From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 084AC47CD9 for ; Wed, 14 Aug 2024 14:34:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6A93668DB7E; Wed, 14 Aug 2024 17:34:31 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 739EE68DB68 for ; Wed, 14 Aug 2024 17:34:24 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id B673C40004 for ; Wed, 14 Aug 2024 14:34:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1723646063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1jwqWsuF1T7KuFEj8rMXN7EI5OMfOvXRF2yDDYb/82I=; b=EMfFlb8JR9TZelTL+T9ESmuQW03Vt0CzyAuz8MFR8CNFPsWXgyQUtjS9F/rJ4WbdO7zgUL a2ysTV+0REuYF6hZFPftlF6mU3vd9ihaRFHjhv3IH8kZ6t9z2zql3OhRTBzFu10aaEo5I7 8KTv5yiUsJ90zMyM2Us0eJmFiRIErwid8Rch3uAzh9DC1GA+iw0JbJ/gWw3J5ClrnEVHLF dM7v9WtLqTSZSf5UqXL4VlvubmkSZKQ7sFAi84TEgZZrjgYyymrzlqdNAg+BEKzQ543LxP Fb3aQMwZw7I2r1f6hiUPfo3EQBw2lB4CEgDnCbyLxTuUgtKyuRiD0070HH7drg== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Wed, 14 Aug 2024 16:34:20 +0200 Message-ID: <20240814143421.3990034-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240814143421.3990034-1-michael@niedermayer.cc> References: <20240814143421.3990034-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 2/3] avformat/mxfdec: Check that key was read sucessfull X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Fixes: use of uninitialized value Fixes: 70932/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-4870202133643264 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mxfdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index af0c8a31007..4d5cb28d6dd 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1533,7 +1533,8 @@ static int mxf_read_indirect_value(void *arg, AVIOContext *pb, int size) if (size <= 17) return 0; - avio_read(pb, key, 17); + if (avio_read(pb, key, 17) != 17) + return AVERROR_INVALIDDATA; /* TODO: handle other types of of indirect values */ if (memcmp(key, mxf_indirect_value_utf16le, 17) == 0) { return mxf_read_utf16le_string(pb, size - 17, &tagged_value->value); -- 2.45.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".